Re: [PATCH v4 6/8] arm64: dts: qcom: sdm845-google: Add basic audio support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: incorrect sound card model name propagated to crosshatch
--

commit cc7bf455060c791244c0b8599e2eec24bc61fc65
Author: David Heidelberg <david@ixit.cz>

    arm64: dts: qcom: sdm845-google: Add basic audio support
    
    Introduce support for sound card and wire two CS35L36 audio codecs for
    top and bottom speakers.

> diff --git a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
> index f1379857e2742..bc826d211e4a7 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
[ ... ]
> @@ -474,6 +537,39 @@ &qup_uart9_tx {
>  	bias-disable;
>  };
>  
> +&sound {
> +	compatible = "qcom,sdm845-sndcard";
> +	model = "blueline";

[Severity: Low]
Because sdm845-google-common.dtsi is shared and included by the Pixel 3 XL
board file (sdm845-google-crosshatch.dts), does this hardcoded ALSA sound
card model incorrectly propagate to crosshatch devices?

Since crosshatch does not override the &sound node's model property, its sound
card will identify itself as 'blueline' to userspace ALSA subsystems (e.g.,
UCM profiles).

Should this use a generic name here and get overridden in the leaf dts instead?

> +	pinctrl-0 = <&quat_mi2s_active>, <&quat_mi2s_sd0_active>,
> +		    <&quat_mi2s_sd1_active>;
> +	pinctrl-names = "default";
> +
> +	/* mm[0-9]-dai-link nodes must be positioned first regardless of sorting */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-pixel3-audio-v4-0-85b5d133aa5e@ixit.cz?part=6