From: Stefan Berger <stefanb@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: armenon@redhat.com, marcandre.lureau@gmail.com,
"Stefan Berger" <stefanb@linux.ibm.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PATCH v2 06/10] hw/tpm: crb: Do not clear internal buffers when backend is busy
Date: Thu, 24 Sep 2026 10:40:22 -0400 [thread overview]
Message-ID: <20260924144026.953360-7-stefanb@linux.ibm.com> (raw)
In-Reply-To: <20260924144026.953360-1-stefanb@linux.ibm.com>
While the backend (thread) is accessing the request and response buffers,
do not clear those buffers upon a command cancellation. Still clear them
in all other cases, though.
Fixes: 29315d22b259 ("hw/tpm: Add internal buffer state for chunking")
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
hw/tpm/tpm_crb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c
index 54fa2042b5..e5e33a3a2f 100644
--- a/hw/tpm/tpm_crb.c
+++ b/hw/tpm/tpm_crb.c
@@ -218,8 +218,9 @@ static void tpm_crb_mmio_write(void *opaque, hwaddr addr,
if (val == CRB_CANCEL_INVOKE) {
if (s->regs[R_CRB_CTRL_START] & CRB_START_INVOKE) {
tpm_backend_cancel_cmd(s->tpmbe);
+ } else {
+ tpm_crb_clear_internal_buffers(s);
}
- tpm_crb_clear_internal_buffers(s);
}
break;
case A_CRB_CTRL_START:
--
2.55.0
next prev parent reply other threads:[~2026-09-24 14:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 14:40 [PATCH v2 00/10] Fix a couple of issues in TPM related code Stefan Berger
2026-09-24 14:40 ` [PATCH v2 01/10] tpm_util: Pass TPMVersion to function writing fatal error response Stefan Berger
2026-09-24 14:40 ` [PATCH v2 02/10] tpm_emulator: Reject TPM responses whose size is too small Stefan Berger
2026-09-24 14:40 ` [PATCH v2 03/10] tpm_emulator: Reject sending commands smaller than the request header Stefan Berger
2026-09-24 14:40 ` [PATCH v2 04/10] hw/tpm: tis: Only read from response buffer if rw_offset < len Stefan Berger
2026-09-24 14:40 ` [PATCH v2 05/10] hw/tpm: tis: Use uint32_t for len to avoid truncating size of command Stefan Berger
2026-09-24 14:40 ` Stefan Berger [this message]
2026-09-24 14:40 ` [PATCH v2 07/10] hw/tpm: crb: Avoid potential integer underflow Stefan Berger
2026-09-24 14:40 ` [PATCH v2 08/10] hw/tpm: crb: Implement tpm_ppi_uninit and use it in tpm_crb_unrealize Stefan Berger
2026-09-24 14:40 ` [PATCH v2 09/10] hw/tpm: crb: Consider response_buffer->len of received response Stefan Berger
2026-09-24 14:40 ` [PATCH v2 10/10] tests: Add tests with commands with bad length Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924144026.953360-7-stefanb@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=armenon@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.