Re: [PATCH net-next v4 2/5] dt-bindings: net: realtek,rtl9301-mdio: add clock-frequency

[Rob Herring <robh@kernel.org>]

On Wed, Sep 16, 2026 at 01:35:12PM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider:
> 
> Critical: 0 · High: 0 · Medium: 0 · Low: 2
> 
> - [Low] Concern (validated as a FALSE POSITIVE, retained only per the
>   retention policy): 'the binding adds a per-bus clock-frequency…
> - [Low] Redundant re-declaration of the common `clock-frequency` property
>   in Documentation/devicetree/bindings/net/realtek,rtl9301-mdio.yaml.
> 
> --
> 
> dt-bindings: net: realtek,rtl9301-mdio: add clock-frequency
> 
> This documents the MDC frequencies supported by the Realtek Otto switch
> MDIO controllers, adding per-family clock-frequency value sets and
> describing the shared frequency selector on RTL839x.
> 
> > diff --git a/Documentation/devicetree/bindings/net/realtek,rtl9301-mdio.yaml b/Documentation/devicetree/bindings/net/realtek,rtl9301-mdio.yaml
> > index 7f5b4897487b2..c5f2289dc0eb2 100644
> > --- a/Documentation/devicetree/bindings/net/realtek,rtl9301-mdio.yaml
> > +++ b/Documentation/devicetree/bindings/net/realtek,rtl9301-mdio.yaml
> > @@ -56,6 +56,9 @@ patternProperties:
> >        reg:
> >          maxItems: 1
> >  
> > +      clock-frequency:
> > +        $ref: /schemas/types.yaml#/definitions/uint32
> > +
> 
> [Severity: Low]
> This isn't a bug, but is this declaration needed at all?  The mdio-bus
> child subschema already does:
> 
>   '^mdio-bus@[0-3]$':
>     $ref: mdio.yaml#
> 
> and Documentation/devicetree/bindings/net/mdio.yaml already declares the
> property:
> 
>   clock-frequency:
>     description:
>       Desired MDIO bus clock frequency in Hz. Values greater than IEEE 802.3
>       defined 2.5MHz should only be used when all devices on the bus support
>       the given clock speed.
> 
> So the property is already permitted by the referenced schema, and its type
> is known to dtschema without an explicit uint32 $ref.  Other in-tree
> bindings rely on that, for example mscc,miim.yaml uses a bare
> "clock-frequency: true" and microchip,pic64hpsc-mdio.yaml declares
> clock-frequency with only a default.
> 
> The per-family enum blocks added below in the allOf if-then sections are
> what actually restrict the accepted values, and those work independently of
> this declaration.  Could this block be dropped so the common property is
> only described in mdio.yaml?

Sashiko is correct.

Rob