Re: [PATCH] ext4: mark data=journal as deprecated and will be removed in January 2028.

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ext4: missing device name in data=journal deprecation warning
--

commit 268d23e9918bb20498a07197e8ffc2af5574d8ca
Author: Theodore Ts'o <tytso@mit.edu>

ext4: mark data=journal as deprecated and will be removed in January 2028.

This commit marks the data=journal mount option as deprecated. It updates
the admin guide documentation and adds a warning during mount indicating
that support will be removed in January 2028.

> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index bca0dc87d0b7c..d636b89090a24 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -5057,6 +5057,7 @@ static int ext4_load_and_init_journal(struct super_block *sb,
>  static int ext4_check_journal_data_mode(struct super_block *sb)
>  {
>  	if (test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_JOURNAL_DATA) {
> +		printk(KERN_WARNING "EXT4-fs: The data=journal mount option is deprecated and support will be removed in January 2028\n");

[Severity: Low]
Does this code omit the filesystem device name from the log message?

Using printk() instead of the standard ext4_msg() helper means that the
superblock's device identifier (e.g., sda1) is not included in the warning.
Should this use ext4_msg(sb, KERN_WARNING, "The data=journal...") so that
administrators managing multiple ext4 filesystems can determine which
specific device is using the deprecated option?

>  		printk_once(KERN_WARNING "EXT4-fs: Warning: mounting with "
>  			    "data=journal disables delayed allocation, "
>  			    "dioread_nolock, O_DIRECT and fast_commit support!\n");

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924145924.341425-1-tytso@mit.edu?part=1