From: Andre Przywara <andre.przywara@arm.com>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
Ben Horgan <ben.horgan@arm.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Fenghua Yu <fenghuay@nvidia.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Srivathsa L Rao <srivathsa.rao@oss.qualcomm.com>,
Ganapatrao Kulkarni <ganapatrao.kulkarni@oss.qualcomm.com>,
Trilok Soni <tsoni@quicinc.com>,
Srinivas Ramana <sramana@qti.qualcomm.com>,
Niyas Sait <niyas.sait@arm.com>, Lee Trager <lee@trager.us>,
Ritwick Sharma <ritwick.sharma@arm.com>,
Gavin Shan <gshan@redhat.com>,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v11 06/13] arm_mpam: propagate MSC access errors for state saving function
Date: Thu, 24 Sep 2026 17:27:32 +0200 [thread overview]
Message-ID: <20260924152739.2865510-7-andre.przywara@arm.com> (raw)
In-Reply-To: <20260924152739.2865510-1-andre.przywara@arm.com>
Allow the mpam_save_mbwu_state() function to return an error, and
propagate read and write errors from the lower level up.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
Reviewed-by: Ben Horgan <ben.horgan@arm.com>
Reviewed-by: Gavin Shan <gshan@redhat.com>
Tested-by: Gavin Shan <gshan@redhat.com> # on NVIDIA Grace Hopper
---
drivers/resctrl/mpam_devices.c | 29 ++++++++++++++++++++++-------
1 file changed, 22 insertions(+), 7 deletions(-)
diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c
index 6a514cc9251ec..f1af249744d2e 100644
--- a/drivers/resctrl/mpam_devices.c
+++ b/drivers/resctrl/mpam_devices.c
@@ -1842,22 +1842,37 @@ static int mpam_save_mbwu_state(void *arg)
mon_sel = FIELD_PREP(MSMON_CFG_MON_SEL_MON_SEL, i) |
FIELD_PREP(MSMON_CFG_MON_SEL_RIS, ris->ris_idx);
- mpam_write_monsel_reg(msc, CFG_MON_SEL, mon_sel);
- mpam_read_monsel_reg(msc, CFG_MBWU_FLT, &cur_flt);
- mpam_read_monsel_reg(msc, CFG_MBWU_CTL, &cur_ctl);
- mpam_write_monsel_reg(msc, CFG_MBWU_CTL, 0);
+ ret = mpam_write_monsel_reg(msc, CFG_MON_SEL, mon_sel);
+ if (ret)
+ return ret;
+ ret = mpam_read_monsel_reg(msc, CFG_MBWU_FLT, &cur_flt);
+ if (ret)
+ return ret;
+ ret = mpam_read_monsel_reg(msc, CFG_MBWU_CTL, &cur_ctl);
+ if (ret)
+ return ret;
+ ret = mpam_write_monsel_reg(msc, CFG_MBWU_CTL, 0);
+ if (ret)
+ return ret;
if (mpam_ris_has_mbwu_long_counter(ris)) {
ret = mpam_msc_read_mbwu_l(msc, &val);
if (ret)
return ret;
- mpam_msc_zero_mbwu_l(msc);
+ ret = mpam_msc_zero_mbwu_l(msc);
+ if (ret)
+ return ret;
} else {
u32 val32;
- mpam_read_monsel_reg(msc, MBWU, &val32);
+ ret = mpam_read_monsel_reg(msc, MBWU, &val32);
+ if (ret)
+ return ret;
val = val32;
- mpam_write_monsel_reg(msc, MBWU, 0);
+
+ ret = mpam_write_monsel_reg(msc, MBWU, 0);
+ if (ret)
+ return ret;
}
cfg->mon = i;
--
2.43.0
next prev parent reply other threads:[~2026-09-24 15:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 15:27 [PATCH v11 00/13] arm_mpam: Add MPAM-Fb firmware support Andre Przywara
2026-09-24 15:27 ` [PATCH v11 01/13] arm_mpam: let low level MSC accessors return an error Andre Przywara
2026-09-24 15:27 ` [PATCH v11 02/13] arm_mpam: propagate MSC access errors for hw_probe functions Andre Przywara
2026-09-30 14:01 ` Ben Horgan
2026-09-30 15:57 ` Andre Przywara
2026-09-30 16:16 ` Ben Horgan
2026-09-24 15:27 ` [PATCH v11 03/13] arm_mpam: propagate MSC access errors for MBWU counters Andre Przywara
2026-09-24 15:27 ` [PATCH v11 04/13] arm_mpam: propagate MSC access errors for msmon helpers Andre Przywara
2026-09-24 15:27 ` [PATCH v11 05/13] arm_mpam: propagate MSC access errors for __ris_msmon_read() Andre Przywara
2026-09-24 15:27 ` Andre Przywara [this message]
2026-09-24 15:27 ` [PATCH v11 07/13] arm_mpam: propagate MSC access errors for mpam_reprogram_ris_partid() Andre Przywara
2026-09-24 15:27 ` [PATCH v11 08/13] arm_mpam: propagate MSC access errors for interrupt control Andre Przywara
2026-09-24 22:20 ` Jonathan Cameron
2026-10-01 15:01 ` Andre Przywara
2026-09-24 15:27 ` [PATCH v11 09/13] arm_mpam: propagate MSC access errors in mpam_reset_class_locked() Andre Przywara
2026-09-24 22:21 ` Jonathan Cameron
2026-09-24 15:27 ` [PATCH v11 10/13] arm_mpam: prepare mon_sel locking for MPAM-Fb Andre Przywara
2026-09-24 15:27 ` [PATCH v11 11/13] arm_mpam: add MPAM-Fb MSC firmware access support Andre Przywara
2026-09-30 14:07 ` Ben Horgan
2026-09-30 15:09 ` Andre Przywara
2026-09-30 16:14 ` Ben Horgan
2026-10-01 14:58 ` Andre Przywara
2026-09-24 15:27 ` [PATCH v11 12/13] arm_mpam: change MPAM-Fb error IRQ to use a threaded IRQ handler Andre Przywara
2026-09-24 22:36 ` Jonathan Cameron
2026-09-24 15:27 ` [PATCH v11 13/13] arm_mpam: detect and enable MPAM-Fb PCC support Andre Przywara
2026-09-30 14:15 ` Ben Horgan
2026-09-30 16:41 ` Andre Przywara
2026-09-30 16:46 ` Ben Horgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924152739.2865510-7-andre.przywara@arm.com \
--to=andre.przywara@arm.com \
--cc=ben.horgan@arm.com \
--cc=catalin.marinas@arm.com \
--cc=fenghuay@nvidia.com \
--cc=ganapatrao.kulkarni@oss.qualcomm.com \
--cc=gshan@redhat.com \
--cc=guohanjun@huawei.com \
--cc=james.morse@arm.com \
--cc=jic23@kernel.org \
--cc=lee@trager.us \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=niyas.sait@arm.com \
--cc=rafael@kernel.org \
--cc=reinette.chatre@intel.com \
--cc=ritwick.sharma@arm.com \
--cc=sramana@qti.qualcomm.com \
--cc=srivathsa.rao@oss.qualcomm.com \
--cc=sudeep.holla@kernel.org \
--cc=tsoni@quicinc.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.