Re: [PATCH 4/8] virtio-usb: add OTG role query support

[sashiko-bot@kernel.org]

> With both host_role and device_role negotiated, a port's own role is
> ambiguous (host|device) - determining it requires more than reading
> the two feature bits. Introduce a minimal OTG command/event queue
> pair (otg_vq_base, otg_vqueues[], otg_init()/otg_deinit()) and
> otg_get_role(), a synchronous VIRTIO_USB_CMD_OTG_GET_ROLE request/
> response exchange, and query every port's role individually during
> probe instead of the alternative of overloading the config space
> ports field with role bits.
> 
> This replaces the previous commit's DEVICE-only placeholder for the
> both-roles-negotiated case with the real per-port answer.
> 
> Signed-off-by: Igor Skalkin <igor.skalkin@oss.qualcomm.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924160907.145405-1-igor.skalkin@oss.qualcomm.com?part=4