Re: [PATCH v9 22/22] KVM: arm64: selftests: Add test case for Partitioned PMU

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests: code and commit message mismatch for enum pmu_impl
--

commit 46faadbd8c25e77d7c2d05f65dc67de455edf047
Author: Colton Lewis <coltonlewis@google.com>

KVM: arm64: selftests: Add test case for Partitioned PMU

This commit extends the vpmu_counter_access test to run against both the
emulated vPMU and Partitioned PMU. It introduces a new enum to represent
the implementation type and skips out-of-bounds counter access exception
tests when partitioned.

> Introduce enum vpmu_impl (EMULATED_VPMU vs. PARTITIONED_VPMU) and thread
> it through the test setup helpers to configure

[Severity: Low]
This isn't a bug in the code, but there is a mismatch between the commit
message and the actual enum definition. The commit message states it
introduces enum vpmu_impl with values EMULATED_VPMU and PARTITIONED_VPMU.

> diff --git a/tools/testing/selftests/kvm/arm64/vpmu_counter_access.c b/tools/testing/selftests/kvm/arm64/vpmu_counter_access.c
> index 22223395969e0..811f8156cea3c 100644
> --- a/tools/testing/selftests/kvm/arm64/vpmu_counter_access.c
> +++ b/tools/testing/selftests/kvm/arm64/vpmu_counter_access.c
> @@ -25,12 +25,27 @@
>  /* The cycle counter bit position that's common among the PMU registers */
>  #define ARMV8_PMU_CYCLE_IDX		31
>  
> +enum pmu_impl {
> +	EMULATED,
> +	PARTITIONED
> +};

[Severity: Low]
Could the commit message be updated to match the actual enum pmu_impl and
its values used here in vpmu_counter_access.c?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924172928.2110956-1-coltonlewis@google.com?part=22