From: sashiko-bot@kernel.org
To: "Wei Huang" <wei.huang2@amd.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/1] PCI/TPH: Validate the firmware Steering Tag response
Date: Thu, 24 Sep 2026 19:17:00 +0000 [thread overview]
Message-ID: <20260924191701.141891F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260924190543.3424792-1-wei.huang2@amd.com>
> TPH _DSM returns an eight-byte Steering Tag information buffer.
> Checking only the ACPI object type allows a short firmware response
> to be read beyond the end of its buffer.
>
> For safety, require a non-NULL buffer containing the complete value
> before copying it. Use memcpy() so that reading the response does not
> depend on the alignment of the firmware buffer.
>
> Fixes: d2e8a34876ce ("PCI/TPH: Add Steering Tag support")
> Signed-off-by: Wei Huang <wei.huang2@amd.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260924190543.3424792-1-wei.huang2@amd.com?part=1
next prev parent reply other threads:[~2026-09-24 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 19:05 [PATCH 1/1] PCI/TPH: Validate the firmware Steering Tag response Wei Huang
2026-09-24 19:17 ` sashiko-bot [this message]
2026-09-24 19:45 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924191701.141891F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wei.huang2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.