From: sashiko-bot@kernel.org
Cc: linux-security-module@vger.kernel.org
Subject: Re: [PATCH v4 1/2] integrity: Report error code in integrity_audit_msg() call sites
Date: Thu, 24 Sep 2026 20:40:16 +0000 [thread overview]
Message-ID: <20260924204016.B42D01F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260924-report-hash-error-v4-1-196ca6350619@cloudflare.com>
> integrity_audit_msg() hides error codes by wrapping
> integrity_audit_message() which obfuscates the underlying reason for the
> failure.
>
> Update integrity_audit_msg() to take a errno argument, and pass that
> through to integrity_audit_message(). Then update call sites to
> take caller's respective error codes.
>
> ima_appraise_measurement() stores xattr_len as the return code, but
> can replace it with a error code later. Therefore conditionally use
> a code if rc < 0, otherwise report zero. Lastly, conditionally use
> -EINVAL for ima_release_policy().
>
> Signed-off-by: Frederick Lawler <fred@cloudflare.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-report-hash-error-v4-0-196ca6350619@cloudflare.com?part=1
next prev parent reply other threads:[~2026-09-24 20:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 20:34 [PATCH v4 0/2] integrity: Return error codes in audit messages Frederick Lawler
2026-09-24 20:34 ` [PATCH v4 1/2] integrity: Report error code in integrity_audit_msg() call sites Frederick Lawler
2026-09-24 20:40 ` sashiko-bot [this message]
2026-09-25 20:35 ` Enrico Bravi
2026-09-24 20:34 ` [PATCH v4 2/2] integrity: Replace integrity_audit_message() with integrity_audit_msg() Frederick Lawler
2026-09-24 20:39 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924204016.B42D01F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.