Re: [PATCHv3] dt-bindings: mtd: convert IBM NDFC binding to YAML

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: mtd: ibm,ndfc schema rejects modern partitions
--

commit f1a26fcb68368a1ab8dd195e7a927c46335d8315
Author: Rosen Penev <rosenp@gmail.com>

dt-bindings: mtd: convert IBM NDFC binding to YAML

The NDFC NAND flash controller was only described in a legacy text file,
so dtbs_check reported "failed to match any schema". This commit converts
the binding to the YAML format.

> diff --git a/Documentation/devicetree/bindings/mtd/ibm,ndfc.yaml b/Documentation/devicetree/bindings/mtd/ibm,ndfc.yaml
> new file mode 100644
> index 0000000000000..e614c5855b423
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/ibm,ndfc.yaml
[ ... ]
> +  bank-settings:
> +    description: NDFC bank configuration register value.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +
> +  nand:
> +    type: object
> +    description: NAND chip attached to the controller.
> +
> +    properties:
> +      "#address-cells":
> +        const: 1
> +      "#size-cells":
> +        const: 1
> +
> +    patternProperties:
> +      "^partition@[0-9a-f]+$":
> +        $ref: /schemas/mtd/partitions/partition.yaml#/$defs/partition-node
> +        deprecated: true
> +
> +    unevaluatedProperties: false

[Severity: Medium]
Does this strict definition of the nand child node prevent device trees from
using modern partition layouts?

Because unevaluatedProperties is set to false without a reference to
/schemas/mtd/mtd.yaml# or /schemas/mtd/nand-chip.yaml#, the schema will
reject modern generic MTD properties.

For example, if a device tree author updates their DTS files by replacing
deprecated direct partition@ nodes with the modern partitions subnode (using
compatible = "fixed-partitions"), dt_binding_check will fail.

Additionally, the node name nand (without a unit address) does not match the
^nand@[a-f0-9]$ regex in the inherited nand-controller-legacy.yaml.

Could this be updated to allow the correct modern alternatives?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924212240.81857-1-rosenp@gmail.com?part=1