All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: [ardb:efi-panic 11/11] drivers/firmware/efi/libstub/efi-stub-helper.c:826:54: warning: more '%' conversions than data arguments
Date: Thu, 24 Sep 2026 22:00:54 +0800	[thread overview]
Message-ID: <202609242143.wxkynTQV-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git efi-panic
head:   26122a1889cbac101c0fabcddf161a87db4ba38c
commit: 26122a1889cbac101c0fabcddf161a87db4ba38c [11/11] efi/libstub: Implement efi_panic()
config: loongarch-defconfig (https://download.01.org/0day-ci/archive/20260924/202609242143.wxkynTQV-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 6e714c8d91116794cb699cdf80c26afe9cda3ef3)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260924/202609242143.wxkynTQV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609242143.wxkynTQV-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/firmware/efi/libstub/efi-stub-helper.c:826:54: warning: more '%' conversions than data arguments [-Wformat-insufficient-args]
     826 |                 efi_warn("Found panic report from previous boot (%lu bytes)\n");
         |                                                                  ~~^
   drivers/firmware/efi/libstub/efistub.h:77:38: note: expanded from macro 'efi_warn'
      77 |         efi_printk(KERN_WARNING "WARNING: " fmt, ##__VA_ARGS__)
         |                                             ^~~
>> drivers/firmware/efi/libstub/efi-stub-helper.c:838:49: warning: format specifies type 'double' but the argument has type 'const char *' [-Wformat]
     838 |                         efi_err("%a(): Failed to allocate memory\n", __func__);
         |                                  ~~                                  ^~~~~~~~
         |                                  %s
   drivers/firmware/efi/libstub/efistub.h:79:39: note: expanded from macro 'efi_err'
      79 |         efi_printk(KERN_ERR "ERROR: " fmt, ##__VA_ARGS__)
         |                                       ~~~    ^~~~~~~~~~~
   drivers/firmware/efi/libstub/efi-stub-helper.c:841:3: error: use of undeclared identifier 'messsage'; did you mean 'message'?
     841 |                 messsage = p;
         |                 ^~~~~~~~
         |                 message
   drivers/firmware/efi/libstub/efi-stub-helper.c:811:22: note: 'message' declared here
     811 |         const efi_char16_t *message;
         |                             ^
   drivers/firmware/efi/libstub/efi-stub-helper.c:809:6: warning: no previous prototype for function 'efi_check_panic' [-Wmissing-prototypes]
     809 | void efi_check_panic(void)
         |      ^
   drivers/firmware/efi/libstub/efi-stub-helper.c:809:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     809 | void efi_check_panic(void)
         | ^
         | static 
   3 warnings and 1 error generated.


vim +826 drivers/firmware/efi/libstub/efi-stub-helper.c

   808	
   809	void efi_check_panic(void)
   810	{
   811		const efi_char16_t *message;
   812		void *p;
   813	
   814		p = get_efi_config_table(capsule_header.guid);
   815	
   816		if (p) {
   817			message = p + sizeof(efi_capsule_header_t);
   818		} else {
   819			unsigned long size = 0;
   820			efi_status_t status;
   821	
   822			get_efi_var(panic_reason, &capsule_header.guid, NULL, &size, NULL);
   823			if (!size)
   824				return;
   825	
 > 826			efi_warn("Found panic report from previous boot (%lu bytes)\n");
   827	
   828			status = efi_bs_call(allocate_pool, EFI_LOADER_DATA, size, &p);
   829			if (status == EFI_SUCCESS)
   830				get_efi_var(panic_reason, &capsule_header.guid, NULL, &size, p);
   831	
   832			/* clear the reason even on allocation failure */
   833			set_efi_var(panic_reason, &capsule_header.guid,
   834				    EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_NON_VOLATILE,
   835				    0, NULL);
   836	
   837			if (status != EFI_SUCCESS) {
 > 838				efi_err("%a(): Failed to allocate memory\n", __func__);

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-09-24 14:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202609242143.wxkynTQV-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=ardb@kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.