From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DCCD456DE9 for ; Thu, 24 Sep 2026 22:01:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790287291; cv=none; b=nS+F4TcZV0518yQnTxKXGXvAlSNoH70PRd/qSyiGIzRa7TEYw8dHVUX8N2PB+9AAp75mMV2bZUgYILGxIdHTHDtEUPzaufLmU43Vepe5TgTrdX/GjMC60P9k/QL4QswSiCzwr0o8r/diNIggBGv3jzK7zhXA3x3P0oFa3YKe5bI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790287291; c=relaxed/simple; bh=499NU1PtnmVpkfZBuubOoR4r215JQRLObkTgcVqFjGo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=MAcFpRbVuvVM3+uv6Ccc1z6ZTgcxWAYHbYnhyp66yb4dQhNIEAtYTeJljCHbTGhBCE+wXM+MUXP0BH6Z+TCfURCvOv+GMgkVqg1i8y7kPOvtd1lRSrhJEI4XmlloYmMZg7ibojF3oW670JqW002LCf/TqPEJ5qowVNFlWsg6Trs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=lex.la; spf=pass smtp.mailfrom=lex.la; dkim=pass (2048-bit key) header.d=lex.la header.i=@lex.la header.b=b/Y/EowC; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=lex.la Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lex.la Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lex.la header.i=@lex.la header.b="b/Y/EowC" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49e66390995so1579115e9.2 for ; Thu, 24 Sep 2026 15:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lex.la; s=google; t=1790287287; x=1790892087; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:content-type:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=V+e7D3v2xQYVCmBJ2WfNuPIPZ5y1VyPpnDFgQMHUqTY=; b=b/Y/EowCZD54EtudeBVWuGzu4YutfdiDetZA+ewJLxN0oxTMGz4pJVzy8BPPgvcl2a W8BBpu3lhR3o8jsYGOh20p4forV3AsfHgG+/jSkEzs9+U5KV4Yuvoyc3/ylHuAkKIZ2q kY/ejaAr8WIhWLm7sEhfFydoZZ5H5gWOty8fhxsEo2Qz2GSdMIJjDS6MM4MmB7eLgd64 pCOWDloYFPVo/1Z9GQ4PPA8NyZ1qMaeo4JBIheuiPZXcwlhaUF2TvuKt+adtX5ZJ36w6 y+VP9D+sZw6bHpHC1GDDKLDC4g0ah6hfgetFcEBLr1Gau+0KkfDzcPG756sZyZONYrYi OCkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790287287; x=1790892087; h=content-transfer-encoding:mime-version:content-type:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=V+e7D3v2xQYVCmBJ2WfNuPIPZ5y1VyPpnDFgQMHUqTY=; b=lV8zMULRivCg+s0OLHXjGA/TcmgEWmERAU+B6k1bVpuVSoKkXkfFWYfgOdiJppR4jM KAvmc35mCXswzW9/mQBDvXwCxw6BPcVWz1Nbkc1ZFtoEe2IW5fXeSDmHVCxbH5o+PBGA ePY/tr9Xgsz65bjl2AddZizk3sevnV9q5VZWivYjkjzXENzbRseWfTxkjdUQUpNU+djd nQkwCyyONLGU78RHR05jX6UUO3nc5i2/a6/TOSzDBmWZKuJKV87sm9SjQW4ywZYhokPz yUDmXhdzlkg08J/AMbLBWFHO9BrI8QgjRcdPKIeBvMG+yrAR+7Q9uDLJH+B7kGqFPss9 v4mA== X-Forwarded-Encrypted: i=1; AKwUvBzHQ5YdDPc8xcyRau7FCvdERnI5QLG2xk0l5FQ/Oh26KBbogMn4i7fwaTDrIDR2mVqUldXfrmw=@vger.kernel.org X-Gm-Message-State: AFuF++mBZPw7XDyn4oYKIxUH4BNzdmDwR066Z5avip1+I8cEHEHfNQZt 3gB6mQiJXDsm/K18WyNPa92yTL6bHqiBuGk3t1Qk9hhPVzgn0+HE1Jm6ljXIzQ93bL0= X-Gm-Gg: AYBFou2TQjOlr5gFuXLsnDt3JWI7nnvSXT/NTZD95O9hyAJha57N6sOhE/2x0zkL42M av4b06ROd/NHt0BEo5sTwVXAEZSmH8ACK9sgkHikM3DxmiHXKDpSf1aMj+cKZGvf8+e8Yo32W1V 66vK6kbMgr4nXABPCQA8Esf9KDBR6eR+qpWLbrQWBPmAOaGArpLkDqPBDCH72kTOheRsUuCMn8J 5mEUDoIz9V7Poe3FLWp5NPOVzA+ewMk4NNJ5uehWGK7ZfKlTOY0itppPOrAeW0189FrIs+rsf8w zW9zug4WDykgihj8Nnyuoq1Sl4KrSmn26tVviyKwMH/Ej/M3kyncPQDXA6xms785x0K/nLeKIIz Z0PKe8mHG5LH1S/qGcNG6XfIZEuAoWMHGH2WctbKZSq1a//bJz+DVd69jAo4RIQFrHbSjeR/Uud 9ibDKwA5aZpQ+foCZZ2jUXjo5Q//w+W7R2ZkXnGsKCLIjXVfccUw== X-Received: by 2002:a05:600c:609a:b0:49c:dca2:ac47 with SMTP id 5b1f17b1804b1-49ff06b2db4mr5253255e9.2.1790287287166; Thu, 24 Sep 2026 15:01:27 -0700 (PDT) Received: from remote-01 ([84.17.55.134]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ff069d071sm10315615e9.5.2026.09.24.15.01.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 15:01:26 -0700 (PDT) From: Aleksei Sviridkin To: Maxime Chevallier Cc: davem@davemloft.net, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , Heiner Kallweit , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?utf-8?q?K=C3=B6ry?= Maincent , Marek =?utf-8?q?Beh=C3=BAn?= , Oleksij Rempel , =?utf-8?q?Nicol=C3=B2?= Veronese , Simon Horman , mwojtas@chromium.org, Romain Gantois , Daniel Golle , Dimitri Fedrau , Frank Wunderlich , Pietro Ameruoso Subject: Re: [PATCH RESEND net-next v17 09/10] net: ethtool: Introduce ethtool command to list ports Date: Fri, 25 Sep 2026 01:01:24 +0300 Message-ID: <20260924220124.2129700-1-f@lex.la> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260910170103.1029108-10-maxime.chevallier@bootlin.com> References: <20260910170103.1029108-1-maxime.chevallier@bootlin.com> <20260910170103.1029108-10-maxime.chevallier@bootlin.com> Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 10 Sep 2026 19:01:01 +0200, Maxime Chevallier wrote: > --- /dev/null > +++ b/net/ethtool/port.c > [...] > + ret = ethnl_put_bitset(skb, ETHTOOL_A_PORT_SUPPORTED_INTERFACES, > + reply->interfaces, NULL, > + PHY_INTERFACE_MODE_MAX, > + phy_interface_names, compact); The supported-interfaces bits are raw phy_interface_t values. OpenWrt's layerscape kernel inserts PHY_INTERFACE_MODE_2500SGMII between 2500BASEX and 5GBASER, so on that kernel every bit above 2500BASEX means something different than on mainline. With compact bitsets userspace cannot notice. A string set or a uAPI enum for these names would fix the numbering. Aleksei