From: sashiko-bot@kernel.org
To: "Nick Desaulniers" <ndesaulniers@google.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Bill Wendling" <morbo@google.com>,
"Ben Cressey" <ben@cressey.dev>,
"Mark Rutland" <mark.rutland@arm.com>,
"Justin Stitt" <justinstitt@google.com>,
"Pasha Tatashin" <pasha.tatashin@soleen.com>
Cc: llvm@lists.linux.dev, stable@vger.kernel.org,
kexec@lists.infradead.org, "David Woodhouse" <dwmw@amazon.co.uk>,
linux-arm-kernel@lists.infradead.org,
"Sami Tolvanen" <samitolvanen@google.com>,
linux-kernel@vger.kernel.org, "Kees Cook" <kees@kernel.org>
Subject: Re: [PATCH] arm64: kexec: mark machine_kexec() __nocfi
Date: Thu, 24 Sep 2026 22:48:05 +0000 [thread overview]
Message-ID: <20260924224805.DC6151F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260924-arm64-kexec-nocfi-v1-1-bbae2e2eadc8@cressey.dev>
> When the loaded image needs relocation, machine_kexec() makes an
> indirect call into the copy of arm64_relocate_new_kernel in the control
> page:
>
> kernel_reloc = (void *)kimage->arch.kern_reloc;
> kernel_reloc(kimage);
>
> With CONFIG_CFI=y the kCFI check on this call loads a type hash from
> kern_reloc - 4. arm64_relocate_new_kernel is SYM_CODE_START and carries
> no hash. Its copy also sits at the start of the control page, which is
> all that TTBR0 maps at this point, so the load faults and the kernel
> oopses after "Bye!" instead of entering the new kernel:
>
> Unable to handle kernel paging request at virtual address 00000000544bfffc
> Internal error: Oops: 0000000096000007 [#1] SMP
> [ ... ]
> ("x86/kexec: Mark machine_kexec() with __nocfi") did on x86.
>
> Fixes: efc2d0f20a9d ("arm64: kexec: keep MMU enabled during kexec relocation")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ben Cressey <ben@cressey.dev>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-arm64-kexec-nocfi-v1-1-bbae2e2eadc8@cressey.dev?part=1
next prev parent reply other threads:[~2026-09-24 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 22:42 [PATCH] arm64: kexec: mark machine_kexec() __nocfi Ben Cressey
2026-09-24 22:48 ` sashiko-bot [this message]
2026-09-25 2:14 ` Kees Cook
2026-09-25 10:52 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924224805.DC6151F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ben@cressey.dev \
--cc=catalin.marinas@arm.com \
--cc=dwmw@amazon.co.uk \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pasha.tatashin@soleen.com \
--cc=samitolvanen@google.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.