From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9971A3914FE; Fri, 25 Sep 2026 04:35:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790310919; cv=none; b=lcCZDXpfRiVDIvvZOzzY+MDiIp7YUK2N9xne9cFoiX1Wlo9iGTRyFmmcmIyIBHlFAKajXJ+JYreooIIhIM871AcmSeaeGbbDAMzCPG3pa8fl9aTtIhR6z7gZsV03OQdtHGysfNvovY1kNQGqwPYvyu0eKyFSkNdUGFd0djRZa60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790310919; c=relaxed/simple; bh=+lNTctq/ERYY61t8s5+zegEQhCAK1oiAnFou5SaBUII=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DTWfj5EYdObHnlwmnX4yu1660Oy56uaKtfOtkKqARtYaWc3H5dLg/xdLbMV/PlfhlURk1UrSB8bZdGPW46EmOUyEkAEHnlUbesRhU+HcTgiaIiudkQvetL1nUsJ1DECAAj5AIAMT6j9g7vS5fbyOaAhSpuqGs9L8hz+fH9+E3fw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LgJqt2NW; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LgJqt2NW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D34AD1F000FF; Fri, 25 Sep 2026 04:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790310918; bh=zhr096L6XvbdPA3YcsFKVElUuzXOCYo2Y4MR6wHtjpo=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=LgJqt2NWo6BFs/+wgDPyGBTzIsX/1RvRLX+mnaNexso4Gf46fMt7p6RykygWjkYKh CJEizl1or0wBC3zFbQJedjNWAFUTGkCreAZPQ8L/tcJbe9dO8w7vdFlqOhly+QwvRU ZuzV8kZiyYD7yNY/IQSrHitpV4KkXEkSHRydpv8Da2dQU810R5UJKx50RAd3vnebY8 8c7U6FCwYCdTAkCglGoiVDjvgL2C9s5QeQSVbvOR71u5a29aAFRPUxzEc8NTEtV6ZW 7dHpBx1o5pRWyGkHhxq9EpUgt4b55ZnI6wH1Ahl8gVYepIJAV2PYe0JvL9x/QkkBxm HVq8Bk6FVHaSA== Date: Thu, 24 Sep 2026 21:35:16 -0700 From: Eric Biggers To: Andrey Albershteyn Cc: djwong@kernel.org, hch@lst.de, Carlos Maiolino , fsverity@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-btrfs@vger.kernel.org, david@fromorbit.com Subject: Re: [PATCH v16 05/21] fsverity: don't allow setting DAX file attribute on fsverity files Message-ID: <20260925043516.GB112369@sol> References: <20260918111539.1003439-1-aalbersh@kernel.org> <20260918111539.1003439-6-aalbersh@kernel.org> Precedence: bulk X-Mailing-List: fsverity@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260918111539.1003439-6-aalbersh@kernel.org> On Fri, Sep 18, 2026 at 01:15:17PM +0200, Andrey Albershteyn wrote: > When fsverity is enabled on the file, with FS_IOC_ENABLE_VERITY ioctl(), > it checks if file has DAX enabled and fails if that's true. However, the > opposite case is not checked. > > Note, that the only other filesystem supporting DAX and fsverity is > ext4, and ext4 does check for this case. > > Signed-off-by: Andrey Albershteyn > Reviewed-by: Christoph Hellwig > Reviewed-by: "Darrick J. Wong" > --- > fs/file_attr.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) Reviewed-by: Eric Biggers - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CA18C98306 for ; Fri, 25 Sep 2026 04:35:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MHH8gxxdU0c75aIKtN4w9HwDZBOM5Yv/a4clxyZu3f4=; b=MDKbE7PHwi0CrjxWfjk4w6Oe+0 DUDGuECZbi5RqJ9Gv23Qq1cLxbgFLhXDG0aO0DrnrI9ToaH2sfSYBn/geO69jXG3jNCzZBsPjhltP eP2k/j4iUhGXEsmfGTiTREFVFa49i+fA1k8O/G4ktaseZR0s5ENNT+T6lA0haEywJPxg=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1x9xef-00034g-Of; Fri, 25 Sep 2026 04:35:25 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1x9xee-00034Z-G7 for linux-f2fs-devel@lists.sourceforge.net; Fri, 25 Sep 2026 04:35:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zhr096L6XvbdPA3YcsFKVElUuzXOCYo2Y4MR6wHtjpo=; b=YyQVb5pEBnsnE5hjC4EP0j5qbb 1qaZ9oAmRxnRArmT9RkBbKXaDaOVEedVwi8xYjdtr2HzAjWAf85ifkqnDb67IPiJTy1Skfkl75SSA a0yuXE8I/9JBXSGsosUqVD6Ra0Lja/5+g4+3tbyyNGvEQ35s2aKWCkd5chFVTPzyHN1A=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zhr096L6XvbdPA3YcsFKVElUuzXOCYo2Y4MR6wHtjpo=; b=gIGHGt9koetCb7lLEf9CiAFoRV dAvYIvSrqRBQ1GNwShqnOG4oguiuFcfv14uH/McFE+RCcTC4DWk4fd8vInrlNYBq+l6sQ+SbjXjN1 FcixoQgwlMVTdU3F2K02AEnxAZDJo3waVbNRMJIYrLgDELKP6esH7nXY/yBawq8r593A=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1x9xee-0003PE-2o for linux-f2fs-devel@lists.sourceforge.net; Fri, 25 Sep 2026 04:35:24 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 786836022E; Fri, 25 Sep 2026 04:35:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D34AD1F000FF; Fri, 25 Sep 2026 04:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790310918; bh=zhr096L6XvbdPA3YcsFKVElUuzXOCYo2Y4MR6wHtjpo=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=LgJqt2NWo6BFs/+wgDPyGBTzIsX/1RvRLX+mnaNexso4Gf46fMt7p6RykygWjkYKh CJEizl1or0wBC3zFbQJedjNWAFUTGkCreAZPQ8L/tcJbe9dO8w7vdFlqOhly+QwvRU ZuzV8kZiyYD7yNY/IQSrHitpV4KkXEkSHRydpv8Da2dQU810R5UJKx50RAd3vnebY8 8c7U6FCwYCdTAkCglGoiVDjvgL2C9s5QeQSVbvOR71u5a29aAFRPUxzEc8NTEtV6ZW 7dHpBx1o5pRWyGkHhxq9EpUgt4b55ZnI6wH1Ahl8gVYepIJAV2PYe0JvL9x/QkkBxm HVq8Bk6FVHaSA== Date: Thu, 24 Sep 2026 21:35:16 -0700 To: Andrey Albershteyn Message-ID: <20260925043516.GB112369@sol> References: <20260918111539.1003439-1-aalbersh@kernel.org> <20260918111539.1003439-6-aalbersh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260918111539.1003439-6-aalbersh@kernel.org> X-Headers-End: 1x9xee-0003PE-2o Subject: Re: [f2fs-dev] [PATCH v16 05/21] fsverity: don't allow setting DAX file attribute on fsverity files X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: fsverity@lists.linux.dev, djwong@kernel.org, Carlos Maiolino , david@fromorbit.com, linux-unionfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, hch@lst.de, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, Sep 18, 2026 at 01:15:17PM +0200, Andrey Albershteyn wrote: > When fsverity is enabled on the file, with FS_IOC_ENABLE_VERITY ioctl(), > it checks if file has DAX enabled and fails if that's true. However, the > opposite case is not checked. > > Note, that the only other filesystem supporting DAX and fsverity is > ext4, and ext4 does check for this case. > > Signed-off-by: Andrey Albershteyn > Reviewed-by: Christoph Hellwig > Reviewed-by: "Darrick J. Wong" > --- > fs/file_attr.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) Reviewed-by: Eric Biggers - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel