From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 3/3] shmctl03: Use safe_shmctl(), TST_EXP_LE_LU()
Date: Fri, 25 Sep 2026 08:49:35 +0200 [thread overview]
Message-ID: <20260925064935.GA2387785@pevik> (raw)
In-Reply-To: <20260924112514.2375626-4-pvorel@suse.cz>
Hi,
...
> - if (info.shmmin != 1)
> - tst_res(TFAIL, "shmmin = %li, expected 1", info.shmmin);
> - else
> - tst_res(TPASS, "shmmin = 1");
> + safe_shmctl(__FILE__, __LINE__, 0, IPC_INFO, ((struct shmid_ds *)&info));
> + TST_EXP_LE_LU(info.shmmin, 1);
Ah, TST_EXP_EQ_LU() should have been used.
Also 1st patch should probably be improved => v3.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-09-25 6:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 11:25 [LTP] [PATCH v2 0/3] shmctl03: Fix shmmax clamped to INT_MAX in 32bit compat mode Petr Vorel
2026-09-24 11:25 ` [LTP] [PATCH v2 1/3] tst_assert: Use 'long long' to fix 32bit compat mode truncation Petr Vorel
2026-09-24 13:24 ` [LTP] " linuxtestproject.agent
2026-09-25 6:55 ` Petr Vorel
2026-09-25 8:01 ` [LTP] [RFC] " Petr Vorel
2026-09-24 11:25 ` [LTP] [PATCH v2 2/3] shmctl03: Fix shmmax clamped to INT_MAX in 32bit compat mode Petr Vorel
2026-09-24 11:25 ` [LTP] [PATCH v2 3/3] shmctl03: Use safe_shmctl(), TST_EXP_LE_LU() Petr Vorel
2026-09-25 6:49 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925064935.GA2387785@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.