From: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
To: kuba@kernel.org
Cc: aleksandr.loktionov@intel.com, andrew+netdev@lunn.ch,
anthony.l.nguyen@intel.com, davem@davemloft.net,
edumazet@google.com, horms@kernel.org, jacob.e.keller@intel.com,
jtornosm@redhat.com, netdev@vger.kernel.org, pabeni@redhat.com,
przemyslaw.kitszel@intel.com, rafal.romanowski@intel.com,
sdf@fomichev.me, stable@vger.kernel.org
Subject: Re: [PATCH net 1/4] iavf: return EBUSY if reset in progress or not ready during MAC change
Date: Fri, 25 Sep 2026 09:18:43 +0200 [thread overview]
Message-ID: <20260925071850.53292-1-jtornosm@redhat.com> (raw)
In-Reply-To: <20260915092418.0aafd079@kernel.org>
Hi Jakub,
Would you be ok with dropping patch 1/4 and resubmitting only
patches 2-4?
Patch 1/4 was originally needed to avoid the 2.5s wait during
reset with netdev_lock held. With patch 3/4 replacing the
wait_event with a synchronous send + poll, the original concern
is already addressed. During reset (if necessary), if it times
out it will return, same behavior as the pre-patch code. Patch
1/4 becomes just an extra precaution, not strictly required, so
it can be removed.
The core fix is in patch 3/4 which carries the Fixes: tag.
Patches 2/4 and 4/4 avoid unnecessary VF resets when changing
trust, reducing disruption and wait times.
Thanks
Best regards
José Ignacio
next prev parent reply other threads:[~2026-09-25 7:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 20:45 [PATCH net 0/4][pull request] Fix i40e/ice/iavf VF bonding after netdev lock changes Tony Nguyen
2026-08-21 20:45 ` [PATCH net 1/4] iavf: return EBUSY if reset in progress or not ready during MAC change Tony Nguyen
2026-08-24 19:01 ` Jakub Kicinski
2026-09-15 8:12 ` Jose Ignacio Tornos Martinez
2026-09-15 16:24 ` Jakub Kicinski
2026-09-16 10:12 ` Jose Ignacio Tornos Martinez
2026-09-25 7:18 ` Jose Ignacio Tornos Martinez [this message]
2026-09-25 19:04 ` Jakub Kicinski
2026-08-21 20:45 ` [PATCH net 2/4] i40e: skip unnecessary VF reset when setting trust Tony Nguyen
2026-08-24 19:01 ` Jakub Kicinski
2026-09-15 8:14 ` Jose Ignacio Tornos Martinez
2026-08-21 20:45 ` [PATCH net 3/4] iavf: send MAC change request synchronously Tony Nguyen
2026-08-24 19:01 ` Jakub Kicinski
2026-09-15 8:16 ` Jose Ignacio Tornos Martinez
2026-08-21 20:45 ` [PATCH net 4/4] ice: skip unnecessary VF reset when setting trust Tony Nguyen
2026-08-24 19:01 ` Jakub Kicinski
2026-09-15 8:19 ` Jose Ignacio Tornos Martinez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925071850.53292-1-jtornosm@redhat.com \
--to=jtornosm@redhat.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rafal.romanowski@intel.com \
--cc=sdf@fomichev.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.