Re: [PATCH v2] rtc: ma35d1: fix unchecked IRQ error and IRQ-before-rtcdev ordering

[sashiko-bot@kernel.org]

> platform_get_irq()'s return goes straight into devm_request_irq()'s
> unsigned int param unchecked -- a negative -EPROBE_DEFER becomes a
> huge positive number, so probe fails outright instead of deferring.
> 
> The IRQ is also requested before rtc->rtcdev is allocated. devm
> teardown is LIFO, so unbind or a later probe failure frees rtcdev
> before the IRQ, and an alarm firing in that window has
> ma35d1_rtc_interrupt() touch freed memory.
> 
> Check irq_num for a negative return, and move the IRQ request to
> right after devm_rtc_allocate_device() (its irqwork is already
> initialized there) and before devm_rtc_register_device(), so unbind
> unregisters the device before the IRQ is freed, not after.
> 
> Fixes: dc0684adf3b6 ("rtc: Add driver for Nuvoton ma35d1 rtc controller")
> Reported-by: Sashiko AI review <sashiko-bot@kernel.org>
> Link: https://lore.kernel.org/r/20260918161925.2639130-1-congnt264@gmail.com
> Assisted-by: LLM
> Signed-off-by: Cong Nguyen <congnt264@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925072345.2632042-1-congnt264@gmail.com?part=1