Re: [PATCH v4 04/10] dt-bindings: input: apple: Add DockChannel HID transport

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: non-standard property hid-country-code lacks vendor prefix
--

commit e3509f43ebb443f3e104e1a4db767081a67d80a5
Author: Michael Reeves <michael.reeves077@gmail.com>

dt-bindings: input: apple: Add DockChannel HID transport

This commit adds a devicetree binding for the Apple DockChannel HID
transport. It describes the transport's mailboxes, DART, and HID child
interfaces, including an optional STM child and a keyboard child.

> diff --git a/Documentation/devicetree/bindings/input/apple,t8112-dockchannel-hid.yaml b/Documentation/devicetree/bindings/input/apple,t8112-dockchannel-hid.yaml
> new file mode 100644
> index 0000000000000..c25e072b68687
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/apple,t8112-dockchannel-hid.yaml
[ ... ]
> +  keyboard:
> +    type: object
> +    properties:
> +      hid-country-code:
> +        $ref: /schemas/types.yaml#/definitions/uint32

[Severity: Low]
Does this non-standard property hid-country-code lack a vendor prefix?

Even though HID country code is an industry standard concept, devicetree
naming conventions require custom properties introduced in vendor bindings
to be prefixed (e.g., apple,hid-country-code) or placed in a common
dt-schema file.

Defining hid-country-code directly in an Apple-specific binding within the
keyboard object without a common HID schema backing it can cause namespace
collisions.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-apple-mtp-keyboard-final-v4-0-304c267518f4@gmail.com?part=4