From: sashiko-bot@kernel.org
To: "Arnd Bergmann" <arnd@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf: marvell: avoid large stack variables
Date: Fri, 25 Sep 2026 13:08:51 +0000 [thread overview]
Message-ID: <20260925130852.4966A1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260925130440.4107512-1-arnd@kernel.org>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The probe function in this driver constructs multiple large structures
> on the stack, which ends up causing a size warning:
>
> drivers/perf/marvell_cn10k_ddr_pmu.c:1168:12: error: stack frame size (1296) exceeds limit (1280) in 'cn10k_ddr_perf_probe' [-Werror,-Wframe-larger-than]
> 1168 | static int cn10k_ddr_perf_probe(struct platform_device *pdev)
> | ^
>
> Avoid this warning and simplify the code by turning these into static
> const structures and directly assigning them without the extra copy.
>
> Fixes: 9b551a2446b2 ("perf: marvell: Add CN20K DDR PMU support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260925130440.4107512-1-arnd@kernel.org?part=1
next prev parent reply other threads:[~2026-09-25 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 13:04 [PATCH] perf: marvell: avoid large stack variables Arnd Bergmann
2026-09-25 13:08 ` sashiko-bot [this message]
2026-10-04 22:09 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925130852.4966A1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=arnd@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.