From: sashiko-bot@kernel.org
To: "Eva Kurchatova" <eva.kurchatova@virtuozzo.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] selftests: pci_endpoint: skip when the test device is absent
Date: Fri, 25 Sep 2026 13:36:43 +0000 [thread overview]
Message-ID: <20260925133643.7FA931F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260925133141.3634476-1-eva.kurchatova@virtuozzo.com>
> Every fixture opens /dev/pci-endpoint-test.0 and asserts on the result,
> so on a machine that has no PCI endpoint test device all 17 cases fail
> in fixture setup rather than reporting that the hardware is not there.
>
> Check for the device once before handing over to the harness. Doing it
> there rather than in each of the four fixtures keeps it to a single skip,
> and leaves the fixtures to fail as before on an open that goes wrong for
> any other reason, which is not something to skip over.
>
> The harness parses its own arguments inside test_harness_run(), so only
> the plain invocation, the one kselftest makes, turns into a skip, -l and
> -h keep working on a machine without the device.
>
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260925133141.3634476-1-eva.kurchatova@virtuozzo.com?part=1
prev parent reply other threads:[~2026-09-25 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 13:31 [PATCH] selftests: pci_endpoint: skip when the test device is absent Eva Kurchatova
2026-09-25 13:36 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925133643.7FA931F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eva.kurchatova@virtuozzo.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.