Re: [PATCH v9 4/6] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Document MT6765 pin controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] pinctrl: mediatek: DT binding allows drive-strength 16 which driver rejects
--

commit c86bb87060bc7c504b8fa22832cdfbbac4934ccd
Author: Yassine Oudjana <y.oudjana@protonmail.com>

dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Document MT6765 pin controller

The MT6765 pin controller has had a driver for a while, but DT bindings were
never documented for it.

> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
> index 4df6971030416..94117008ebf9f 100644
> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml

[ ... ]

> @@ -61,6 +62,41 @@ required:
>  
>  allOf:
>    - $ref: pinctrl.yaml#
> +  - if:
> +      properties:

[ ... ]

> +      patternProperties:
> +        '-pins$':
> +          patternProperties:
> +            '^pins':
> +              properties:
> +                drive-strength:
> +                  enum: [1, 2, 4, 16]

[Severity: Medium]
Does this binding allow a drive-strength that exceeds the hardware capacity?

The MT6765 driver is configured to pass the device tree drive-strength
value strictly as a raw register value:

drivers/pinctrl/mediatek/pinctrl-mt6765.c:mt6765_data {
    ...
    .drive_set = mtk_pinconf_drive_set_raw,
    ...
}

The core driver then safely rejects values exceeding the 3-bit register mask
(which limits values to at most 7):

drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:mtk_hw_set_value() {
    ...
    if (value < 0 || value > pf.mask)
        return -EINVAL;
    ...
}

Since 16 is greater than the hardware register mask, would device trees
using this value pass schema validation but fail to configure pins during
driver probe?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-mt6735-pinctrl-v9-v9-0-bfb19d8bb87c@protonmail.com?part=4