Re: [PATCH] dt-bindings: dma: Convert hisilicon,k3-dma-1.0 to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: invalid node name in example failing dma-controller.yaml schema
--

commit e8e749663f823d5245b7a4660ed5a57fe7046856
Author: Rob Herring (Arm) <robh@kernel.org>

dt-bindings: dma: Convert hisilicon,k3-dma-1.0 to DT schema

Convert the hisilicon,k3-dma-1.0 binding to DT schema format. Add undocumented
properties and make clocks optional for the hisilicon,hisi-pcm-asp-dma-1.0
hardware.

> diff --git a/Documentation/devicetree/bindings/dma/hisilicon,k3-dma-1.0.yaml b/Documentation/devicetree/bindings/dma/hisilicon,k3-dma-1.0.yaml
> new file mode 100644
> index 0000000000000..7a7aab5f4c66c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/hisilicon,k3-dma-1.0.yaml

[ ... ]

> +additionalProperties: false
> +
> +examples:
> +  - |
> +    dma@fcd02000 {

[Severity: Low]
The dma-controller.yaml schema referenced in the allOf block enforces that
the node name matches the regex pattern ^dma-controller(@.*)?$.

Since this example node is named dma@fcd02000, will it fail validation during
make dt_binding_check? Could this be updated to dma-controller@fcd02000 to
satisfy the schema requirements?

> +        compatible = "hisilicon,k3-dma-1.0";
> +        reg = <0xfcd02000 0x1000>;
> +        #dma-cells = <1>;
> +        dma-channels = <16>;
> +        dma-requests = <27>;
> +        interrupts = <0 12 4>;
> +        clocks = <&pclk>;
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925160354.1722583-1-robh@kernel.org?part=1