From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E505F4DE71C for ; Fri, 25 Sep 2026 16:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790353504; cv=none; b=Gx+kacmRHebdfroNfH3juypvseWC2Bqxrx7nkWzLgVWp4aeSIKWr46YbR83KZ5KDiev4tpEhgLlylbB+cgs2joPJrEBEO/P0WvBi2jNhyLwtZQdUuBfZ0nIJLJd3ppq4PK9IozZgmUgBnVpqQco25QCohpxSDD9vkEGYwjy2Pqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790353504; c=relaxed/simple; bh=mj3SdbpcuVXLFrrUIf3KbnkVRVxd21IkNwP+DxYDJxk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=BmXkkJVYoP/xweue1kFoNOnAUAPuw9Oj5T+zKiEBt0wn4uQdv9y6mfiJzEPR5BrgSCzEK1+eqMSquW7eptCLNHbh+2/oOMcKLfxw8Mn4akA/a+gayj2Iah9PYeMqBfwBJpwh9ca+8ww8bKsPYIjDULfNfUDjLUsUGn0T4PNwaSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--avagin.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=dEskYY5S; arc=none smtp.client-ip=209.85.167.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--avagin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dEskYY5S" Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-4a7de733fa9so1945802b6e.3 for ; Fri, 25 Sep 2026 09:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790353501; x=1790958301; darn=lists.linux.dev; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MtHl8hYmoYmzTRn6TIDSWRUdJUOUFOpNuKrI1Eig3qY=; b=dEskYY5SvbLpg2qVewP10FtCFR8l2KKm1fnSP+XwqTG5ngk2Lpu/1goks8sGpLGPHw R8lWAtFh4aWbIEDMqF2xnOwzurgTuxP91cYkAR+P3oOikDw+cifrTfeIGhpq1tV4pFxp MC0nG4n7YFShrlUkBLFT9exJcgDzXDCUJSr4k2nQD79sZfZlOeM5KZiWSvmVkwtASjjs /6WgDZdp2FeL4+IPjdCkjSVE/QSvHsvmp8KBoLjKP9xOPYV0BcB5KS5gxE5qGXRvlnJU xheYSIatwwe4GzE6XnajsISgE7KS6P2fvxH3mntRbNcIcl+9bV8la0qXml4764bvRf41 uwGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790353501; x=1790958301; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MtHl8hYmoYmzTRn6TIDSWRUdJUOUFOpNuKrI1Eig3qY=; b=vTC8gjjP7wxh9gqXTkR4SNo8FiSaYItOPh4KaYyz0mUDIMPNU1qigJM9P0nG8uWMJX JGsJOwjEthxWJiSjevi/va/uPMOUj8bRVRbl99u/HfIwbBRAJNSddj1DTj3N0QGzeajJ mnKjrUxyuwXIUC4phb8UWFtqlXZpsK6WnUJBrheoKKGP741i++9POqz5C/00FwmUB3ZK CRvI9mDPKFVhWHDTQ8pOOtAjOo1r/oxq7P4y6mBa3l6LKy3/EfzoI/MDGx3J5OoI4VbC wOc2DmiV3EaNUpDyk1ohdI8qa/GHGhTce4+udTWVVUcGsnxx00z1YSVcfARq3DjpMzdO CVNw== X-Forwarded-Encrypted: i=1; AKwUvBy56zLmdI0/+gljGv2IeOenG0sDLx5LHMOdFHq7v+VMYl5BLopJFBwTyAMboM3X8feJp9Cl@lists.linux.dev X-Gm-Message-State: AFuF++l6XKNPpiUDHh3DnWGQAb/Q+t+4Y/Yxx6hlQdjy+PISr4VxePdY ickCMJUUwMJrPrOpffXnxCZFHHGifWoRGXY7IRAXDVax+8bwIRJ/hg8XFcUNDU6wnpYRFfSIiAp vPg1ZaA== X-Received: from iobms17.prod.google.com ([2002:a05:6602:a891:b0:9c4:b4f6:5f87]) (user=avagin job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6808:19a8:b0:4c3:ebb:63d6 with SMTP id 5614622812f47-4d72e06f3d0mr7450761b6e.39.1790353501307; Fri, 25 Sep 2026 09:25:01 -0700 (PDT) Date: Fri, 25 Sep 2026 16:24:50 +0000 In-Reply-To: <20260925162454.1403405-1-avagin@google.com> Precedence: bulk X-Mailing-List: criu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260925162454.1403405-1-avagin@google.com> X-Mailer: git-send-email 2.56.0.rc1.315.gc6ed9934b7-goog Message-ID: <20260925162454.1403405-5-avagin@google.com> Subject: [PATCH 4/7] x86/fpu: Document reasoning of FX-only fallback From: Andrei Vagin To: Borislav Petkov , "Chang S. Bae" Cc: linux-kernel@vger.kernel.org, criu@lists.linux.dev, Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, Andrei Vagin , Alexander Mikhalitsyn , "H. Peter Anvin" Content-Type: text/plain; charset="UTF-8" Add a comment to check_xstate_in_sigframe() to explain the reasoning behind falling back to the FX-only state when signal frame metadata is inconsistent. The fallback is intended to preserve backward compatibility with legacy user-space processes that are not aware of XSAVE states and might only fill or copy the legacy FP state. However, this fallback should be avoided whenever possible. If a process was actively using extended features, falling back to the FX-only state silently resets those extended registers to their initial state, which can lead to silent user-space state corruption. Reviewed-by: Alexander Mikhalitsyn Reviewed-by: Chang S. Bae Signed-off-by: Andrei Vagin --- arch/x86/kernel/fpu/signal.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/x86/kernel/fpu/signal.c b/arch/x86/kernel/fpu/signal.c index b9dcd0cd0e41..d56819fe491e 100644 --- a/arch/x86/kernel/fpu/signal.c +++ b/arch/x86/kernel/fpu/signal.c @@ -54,6 +54,14 @@ static inline bool check_xstate_in_sigframe(struct fxregs_state __user *buf_fx, if (likely(magic2 == FP_XSTATE_MAGIC2)) return true; err_setfx: + /* + * The fallback to FX-only state is used to preserve backward + * compatibility with user-space processes that are not aware of xsave + * states. + * + * In all other cases, returning false (to trigger SIGSEGV) is + * preferred to avoid silent user-space state corruption. + */ trace_x86_fpu_xstate_check_failed(x86_task_fpu(current)); /* Set the parameters for fx only state */ -- 2.56.0.rc1.315.gc6ed9934b7-goog