Re: [PATCH] Add TAINT_DRIVER_OVERRIDE for usage of driver_override

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] bus: undeclared variable 'drv' breaks build in driver_override_store()
- [Low] docs: off-by-one error in tainted-kernels.rst loop bound
--

commit 2d672f63b60203b8c528977d9c5848655d98a583
Author: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

    Add TAINT_DRIVER_OVERRIDE for usage of driver_override
    
    Commit fcbfaffee51a ("driver core: add TAINT_FORCED_BIND for when
    userspace manually messes with devices and drivers") introduced a taint
    for usage of bind/unbind sysfs files that manually trigger driver probe
    and remove respectively.

> diff --git a/Documentation/admin-guide/tainted-kernels.rst b/Documentation/admin-guide/tainted-kernels.rst
> index abbf5e3dd7495..75750a9533e98 100644
> --- a/Documentation/admin-guide/tainted-kernels.rst
> +++ b/Documentation/admin-guide/tainted-kernels.rst
> @@ -74,7 +74,7 @@ a particular type of taint. It's best to leave that to the aforementioned
>  script, but if you need something quick you can use this shell command to check
>  which bits are set::
>  
> -	$ for i in $(seq 20); do echo $(($i-1)) $(($(cat /proc/sys/kernel/tainted)>>($i-1)&1));done
> +	$ for i in $(seq 21); do echo $(($i-1)) $(($(cat /proc/sys/kernel/tainted)>>($i-1)&1));done

[Severity: Low]
Will this script snippet fail to report the newly added bit 21? 

The loop bound `seq 21` generates numbers 1 through 21, which maps to indices
0 through 20 via `$i-1`. This appears to miss the new TAINT_DRIVER_OVERRIDE
bit.

[ ... ]

> diff --git a/drivers/base/bus.c b/drivers/base/bus.c
> index c51ad96d4de4b..6e91210aab452 100644
> --- a/drivers/base/bus.c
> +++ b/drivers/base/bus.c
> @@ -513,6 +513,7 @@ static ssize_t driver_override_store(struct device *dev,
>  {
>  	int ret;
>  
> +	add_taint_module(drv->owner, TAINT_DRIVER_OVERRIDE, LOCKDEP_STILL_OK);

[Severity: Low]
Are we referencing an undeclared variable `drv` here? 

The signature of driver_override_store() only takes `dev`, `attr`, `buf`,
and `count`, so this causes a compilation failure when building bus.c.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925182041.1025371-2-u.kleine-koenig@baylibre.com?part=1