From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo2-f37.google.com (mail-oo2-f37.google.com [74.125.231.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9746416843 for ; Fri, 25 Sep 2026 18:30:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.165 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790361056; cv=none; b=OcUE2VqjKhfrkSx4dgddBmzpYrz3JJ4y2nOZwWiQaeI3mnm10h19PODtCxRI1fkdQgE7FeCsRLkv661gGBUqqGcH/mbtkHaLU9gEbJO5iuTIoCMf38eSiEJvcbNAaVdYO+maGC57s7Nwd0KEjjx7u4HofGrLO0waX3TTv4XJ3KM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790361056; c=relaxed/simple; bh=5bTeIx/3s3lWKZ4nDNCgKXw7Rt+gYVbleVn2IGZZ9Yw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fHBtBi+6ntSmoL8Wd+TuNOtSG5K8ujA5WRkM/d5N5D+bsabTQUkImefZ0iIgdYhkVEoE//FJjot4HeJet4+9mhSgm0YD0z/GEyOSoiPJ19lrcM+lwv/cYlDjyafgZYMXDCljfwiYuy9QZsQmNl3+Z2NN8ZljJGtrICAcZTw2ed0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U0GnIiDF; arc=none smtp.client-ip=74.125.231.165 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U0GnIiDF" Received: by mail-oo2-f37.google.com with SMTP id 46e09a7af769-805bf8c2661so898625a34.3 for ; Fri, 25 Sep 2026 11:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790361054; x=1790965854; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=cW2XG4Hoqs2N1NPgfs1kba+XBAoXoAzgs1+8F/XNb98=; b=U0GnIiDFUnMHJgw6yHDx5rw6p+Y4ALU+1yCXVcHaNMRaknxDf25EgcXgpqyBfkd6w4 Qb5vvMy/s7FShC7gevlCgIyVJL3Ug5eV2XaEAHuu4NNuYgkkK9BsBNVR0t91JGl3xnLl csr++Kfoe5n338SlprhKWXhgOOcSkJrGNkPLFHHUY5M/67VDqN1QbmuGE/RMSm58JyXt Q7MbnxQad8V2hrMsBeNRvconG7au/rx8Pr6cyo3UyKJHyTx42csynwvkCnAUVe0iW0xk Ts8qixGVnxeTEY/treY+EyQus6i+TI4l+IyLDC3Qgo+yTdlUW7IRG6kOUJkTVh4MmeI8 Xx8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790361054; x=1790965854; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cW2XG4Hoqs2N1NPgfs1kba+XBAoXoAzgs1+8F/XNb98=; b=wK6ue+U/mJikVpQGyx4m5F/N8JZcq/lcSIUf1sK3g1uIv2/+DYrqJSjHvp0VCi/Ajn I+vRS8EBOWvfxkHyhhxE5rxCJKPDM/gABiGjZ0ycfqQX2ioQHwyDeADVZIRwVaQ4k01L XvdKdWVwlIhjCKo3J26gifmQsvY/xXtnHwIZF0bVHoJjwvMpSMa3fXHrm7KEL2hSmewm 9/YpJcjgsEK9j5MBdXiwfp+BKWGmSV3h5+rsdzi7j4b8qsaM0BI9U3PxoHjJLhQme9cv 8ldTFtdkwmgh7TpQEu48P6ARxenZ8E8FBoS35EmSn3UibouDvpTAukNRmuGa8NIgsmaY pbMA== X-Gm-Message-State: AFuF++mrWNbZzTqFsg+iMwi0ot1Ee970iAQZ0YHb75hVBYpY2L6bOzBl qMZsnqI1JdRut3wO1SUOgZZAiNNQDHqRjhlcahYZ9yAveAP4wCO0D0yknhmfVA== X-Gm-Gg: AYBFou2GGGW8pyDSShxnX0AiK5UgWDbR7+mOCG7vonsBawOwmSgSU9XqH/ZIdUFpxqM +u1lcpwBskdAzxGoxTwt/qm3wpLK308esWL4EM38M93mKz/0o3Mai7uDWebJGQZ6en9UTc7KPhX q99lhC6g5hVhDoIrIhfXRfp1hmcKBCfJXKESJ2h8t5Dy2I/J3cpI0Fsw+itkJOAJhbdC4NeCoOK BnsPdB3WihhIkySz8cyL+VsWtd1MCW7aYdABELpbozC2wAWp0JrWVNvEeYe62vqtqQRwIpFGSeE XnMTsXD4d7soaVDXISNGSMV7k8RjkpvHFT2rG6H2kT+vbqgTEEX+tlE9PECN/dG91mVbUMABQQk TQ1o172MHeCEO9Fcc5WDAriL2I/fKIsH+U3rube2yKBftSiwqnZmhWKRlba56sfquxI8vmhFHa/ uE/zrEqzRh3Bh2tFyupXHXYqnN7MAi47tBW2TmBBsydbhoocTLuK6IF/c24MU/f96W/ccKdsdgE TPilmwx36mF2eVar3WXjVi9/8Xo9EbcyviGEVCyrmyH9Z5LlHA/f/wmwnmopxVeRDGv+oNqnH26 mrPOXddYkyooF35Oi6w3soyLTviTwtFXtv5VWpfyPURmc/Xq X-Received: by 2002:a05:6820:4b0c:b0:6c3:2390:c293 with SMTP id 006d021491bc7-6d43e80cbd2mr6577666eaf.32.1790361053750; Fri, 25 Sep 2026 11:30:53 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-818e8beb374sm3181560a34.10.2026.09.25.11.30.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 11:30:52 -0700 (PDT) From: Rosen Penev To: linux-serial@vger.kernel.org Cc: Vineet Gupta , Greg Kroah-Hartman , Jiri Slaby , linux-snps-arc@lists.infradead.org (open list:SYNOPSYS ARC ARCHITECTURE), linux-kernel@vger.kernel.org (open list:TTY LAYER AND SERIAL DRIVERS) Subject: [PATCH] serial: arc_uart: Use platform IRQ helper Date: Fri, 25 Sep 2026 11:30:50 -0700 Message-ID: <20260925183050.56839-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Avoid calling irq_dispose_mapping() by letting the platform_device machinery handle it. Also enable possibility of handling -EPROBE_DEFER and other errors. Handle as early as possible to avoid doing unnecessary work. Signed-off-by: Rosen Penev --- drivers/tty/serial/arc_uart.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c index 3988e5958896..b46b057a181b 100644 --- a/drivers/tty/serial/arc_uart.c +++ b/drivers/tty/serial/arc_uart.c @@ -30,7 +30,6 @@ #include #include #include -#include #include /************************************* @@ -571,12 +570,17 @@ static int arc_serial_probe(struct platform_device *pdev) struct arc_uart_port *uart; struct uart_port *port; int dev_id; + int irq; u32 val; /* no device tree device */ if (!np) return -ENODEV; + irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + dev_id = of_alias_get_id(np, "serial"); if (dev_id < 0) dev_id = 0; @@ -607,7 +611,7 @@ static int arc_serial_probe(struct platform_device *pdev) return PTR_ERR(port->membase); } - port->irq = irq_of_parse_and_map(np, 0); + port->irq = irq; port->dev = &pdev->dev; port->iotype = UPIO_MEM; -- 2.55.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B680C9830E for ; Fri, 25 Sep 2026 18:30:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=78P7mxmjJcOdQaNMhC3snfshfCN9aSdfjaRJryYheN4=; b=XrcZNtcrl6IDXv 4SCG6msUGRlPJLqcrLlCOqAXSVtXmnkwft/u+PJ0BIOthYXJ0t6Ad05Tfk+0MEgi9CLHUdl66Z+yn 8xZYc+YnLlAVujbAnDpmayFMlUxZcn1bJqlrWQjrenlRYGrVSogiS0dPnndFhk/HXW6VxRI/WFYND 5Gz6SCx2OdyC9EljmPTPizGABQDLOELhuEBp3pqh47mX2nYvqR65JTR2kVnG/2D/mYKCgzsFYjG5Z GtxqNK7WmsarCYVyirdnNgx4bElHO8gjs2ZgImYsaRnP1ge5naPV5t55Q2+eQcwY8S2BPSPaEJQak 0an6p0sznWOD1D6GO09Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xAAhF-0000000E9ga-34iW; Fri, 25 Sep 2026 18:30:57 +0000 Received: from mail-oo2-x0e.google.com ([2607:f8b0:4864:31::e]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xAAhD-0000000E9fo-05Zg for linux-snps-arc@lists.infradead.org; Fri, 25 Sep 2026 18:30:56 +0000 Received: by mail-oo2-x0e.google.com with SMTP id 006d021491bc7-6b1ae6b2010so762270eaf.0 for ; Fri, 25 Sep 2026 11:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790361054; x=1790965854; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=cW2XG4Hoqs2N1NPgfs1kba+XBAoXoAzgs1+8F/XNb98=; b=Tk8AaqAGB3QwSBytEOjMTtjEWOlu3lysmQEYeLasTYNsFu6VfQn1Q5uWhMX8qL0BWC dGB+W1kY3dPJVQfLUcjQOmpk4B8nMmEQ54M39udqnSKCoCvXsPC2UOL0goIyVxMIFeW1 zUdhbL3gJe7exMoOr2N9srAWBhRxgra+0TsVj7PHeAjfGwPdZ21EugIdPuZXzH+HLo3G UtLqJZtIcgqQOR7Ds4Zjy5MeQW5VfbPOfRCNo/F/NbPHyo31bBzmA0HvvG2ark5fkx/F h9B32M7Dwjesod7n74LXS4UjbBzT2IYULoTwER2HwzyyM4CO95R5Rxe7PryVGSM9Boum WERw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790361054; x=1790965854; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cW2XG4Hoqs2N1NPgfs1kba+XBAoXoAzgs1+8F/XNb98=; b=NM+tT0qr+8Vr4uBoW+F3lTmdiq3lASS+GWGZOFJo216RkeGmrlkXRfB9LKkjslkNjV Ua1tkaOFoMh5Gm0errZlCcBWSaCJM1Ax51tUVTne31cpE3EF0LweqcDQENIUKjTrQywt DifbGBrENS5TWddjqrrxakrFwpoTJxAt4ZQ6NO5mX+3aDtBMo9XaLKloif6+fmYXqZkW PDFirh+S3u1idej5ScAp6Qgu2uXnf7e1V5cLw1QpI32Z2cK0z4+HqfuaYP0w++VYg//b 6CGghUR72nV0eLPiypc+bPZR7kSeNMjRgqMqO8TyjhB/z5n693c/lR6ltXb7mcegz0Sb h5Ag== X-Forwarded-Encrypted: i=1; AKwUvBzqxDF7RdjoGW3LV3HVj9W14yXqt4f0A3dVxG3lt87XQ8MN3WjID0lvE22FHGArH7OQrab+uDKN7hszRnj0Mg==@lists.infradead.org X-Gm-Message-State: AFuF++kNqqaQDUcMyPrx7svRxfyx437d8jc0Vwjgr9eC6i2UHMUZnOfL dh26Jz6grj6znvUFuWEQPyqt7YQAhv0CMxYcpKPs59i1LZUci/RArVKf X-Gm-Gg: AYBFou23TB+koRmJP9viKKCsKDBTA5eQ4pZ+CC+sOwA6PsJ8M09npi8AvENP4Js4s02 NqqtnCLaL5/NnO3ehH+agzPSwFWj/V2mnUJKrf9frCh9ZL65wwBebGsNxhBEqMBKbhQMT2+lInk RJSMtn9TzY4eOPK6aWOBOXiThv7U0Ec1Qqn8VjI/qlB+/NKQnpYG9zxLyBkz+mr/VMD1WBFpXFB Jy5nZbDJXgd3PKOH1hH8JWycGfzFyevb8MblfuFeBqKi0alJg/7er78AvwcVdsP/Of8s6WEI9dL kluel3oliLperFUuk5rRfIVeyGOR5sNV1+JJYRAJW2YVBqBdcB7FC7wNFcLvp16YFtL5u6ATTDS TIHTf8K+pfC5cYAYqoPbuYv3XG/fIi4zzL91ZvS6lwQufVDEHE6N49v/3ICbLhsiudmUP03eU3j 1cQ00h3uLnMwJPcUqjbbU1TtwF9I2UoRG1snAtZd6T2IVVO4WL1iLbyDp0KsPHCJOXajQwNf8gz GCIbMW+CrVg52ys7dfUq3DmyFVcGrkOhU/EAOr86Vl+wQ8mA5VywFRp7uX7ZnYWjlI2AEcKv6jl tT5fvR+PftANim+DICN8+728j61vKOXp+y95Kl9U7tjg0ibr X-Received: by 2002:a05:6820:4b0c:b0:6c3:2390:c293 with SMTP id 006d021491bc7-6d43e80cbd2mr6577666eaf.32.1790361053750; Fri, 25 Sep 2026 11:30:53 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-818e8beb374sm3181560a34.10.2026.09.25.11.30.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 11:30:52 -0700 (PDT) From: Rosen Penev To: linux-serial@vger.kernel.org Cc: Vineet Gupta , Greg Kroah-Hartman , Jiri Slaby , linux-snps-arc@lists.infradead.org (open list:SYNOPSYS ARC ARCHITECTURE), linux-kernel@vger.kernel.org (open list:TTY LAYER AND SERIAL DRIVERS) Subject: [PATCH] serial: arc_uart: Use platform IRQ helper Date: Fri, 25 Sep 2026 11:30:50 -0700 Message-ID: <20260925183050.56839-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260925_113055_068691_9CD6DF5D X-CRM114-Status: GOOD ( 11.08 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org Avoid calling irq_dispose_mapping() by letting the platform_device machinery handle it. Also enable possibility of handling -EPROBE_DEFER and other errors. Handle as early as possible to avoid doing unnecessary work. Signed-off-by: Rosen Penev --- drivers/tty/serial/arc_uart.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c index 3988e5958896..b46b057a181b 100644 --- a/drivers/tty/serial/arc_uart.c +++ b/drivers/tty/serial/arc_uart.c @@ -30,7 +30,6 @@ #include #include #include -#include #include /************************************* @@ -571,12 +570,17 @@ static int arc_serial_probe(struct platform_device *pdev) struct arc_uart_port *uart; struct uart_port *port; int dev_id; + int irq; u32 val; /* no device tree device */ if (!np) return -ENODEV; + irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + dev_id = of_alias_get_id(np, "serial"); if (dev_id < 0) dev_id = 0; @@ -607,7 +611,7 @@ static int arc_serial_probe(struct platform_device *pdev) return PTR_ERR(port->membase); } - port->irq = irq_of_parse_and_map(np, 0); + port->irq = irq; port->dev = &pdev->dev; port->iotype = UPIO_MEM; -- 2.55.0 _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc