All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Farman <farman@linux.ibm.com>
To: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
	Matthew Rosato <mjrosato@linux.ibm.com>,
	eblake@redhat.com, Eric Farman <farman@linux.ibm.com>
Subject: [PATCH v4 5/5] iotests/iothreads-nbd-export: Skip on s390
Date: Fri, 25 Sep 2026 21:44:09 +0200	[thread overview]
Message-ID: <20260925194409.716498-6-farman@linux.ibm.com> (raw)
In-Reply-To: <20260925194409.716498-1-farman@linux.ibm.com>

Running this test on s390 causes long python exception tracebacks
at the beginning of the system_reset loop. The problem appears to
be the same one described by commit ad302b21aab6, in that QEMU
will exit on s390 without any kernel or boot disk.

In other tests, this is addressed by adding -no-shutdown to the
command line, and that does create a clean failure instead of a
long line of python exceptions:

  --- /home/farman/git/qemu/tests/qemu-iotests/tests/iothreads-nbd-export.out
  +++ /home/farman/git/qemu/build/scratch/qcow2-file-iothreads-nbd-export/iothreads-nbd-export.out.bad
  @@ -16,4 +16,4 @@
   {"return": {}}
   {"return": {}}
   Checking that it is still alive...
  -{"return": {"running": true, "status": "running"}}
  +{"return": {"running": false, "status": "prelaunch"}}
  Failures: iothreads-nbd-export
  Failed 1 of 1 iotests

...but obviously this isn't still a successful test, since it is
expected that the guest will be still be usable after the reset loop.
So, barring a solution to that, just skip this test on s390.

Signed-off-by: Eric Farman <farman@linux.ibm.com>
---
 tests/qemu-iotests/tests/iothreads-nbd-export | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/qemu-iotests/tests/iothreads-nbd-export b/tests/qemu-iotests/tests/iothreads-nbd-export
index 037260729c7..72493ad2279 100755
--- a/tests/qemu-iotests/tests/iothreads-nbd-export
+++ b/tests/qemu-iotests/tests/iothreads-nbd-export
@@ -25,6 +25,11 @@ import iotests
 iotests.script_initialize(supported_fmts=['qcow2'],
                           supported_platforms=['linux'])
 
+# QEMU on s390 will exit without any sort of backing disk,
+# so the reset loop requested by this test will fail.
+if iotests.qemu_default_machine == 's390-ccw-virtio':
+    iotests.notrun('Cannot run test on s390')
+
 with iotests.FilePath('disk1.img') as path, \
      iotests.FilePath('nbd.sock', base_dir=iotests.sock_dir) as nbd_sock, \
      qemu.machine.QEMUMachine(iotests.qemu_prog) as vm:
-- 
2.53.0



  parent reply	other threads:[~2026-09-25 19:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 19:44 [PATCH v4 0/5] iotests fixes Eric Farman
2026-09-25 19:44 ` [PATCH v4 1/5] iotests/nbd-in-qcow2-chain: use default machine Eric Farman
2026-09-25 19:44 ` [PATCH v4 2/5] iotests/nbd-tls-iothread: skip on non-x86 hardware Eric Farman
2026-09-25 19:44 ` [PATCH v4 3/5] iotests/fuse-truncate: skip if FUSE is not usable Eric Farman
2026-09-25 19:44 ` [PATCH v4 4/5] iotests/108: skip if fuse is unusable Eric Farman
2026-10-08 16:23   ` Eric Blake
2026-09-25 19:44 ` Eric Farman [this message]
2026-09-25 21:46 ` [PATCH v4 0/5] iotests fixes Eric Blake
2026-10-07 17:34   ` Eric Farman
2026-10-07 21:40     ` Eric Blake
2026-10-07 22:40       ` Eric Farman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260925194409.716498-6-farman@linux.ibm.com \
    --to=farman@linux.ibm.com \
    --cc=eblake@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.