Re: [PATCH v3 4/4] xfstests: fix permissions on system file installed by libtoolize

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Sep 25, 2026 at 12:45:12PM +0200, Andrey Albershteyn wrote:
> Libtoolize installs set of auxiliary files from its system package.
> Not all distributions have the same permissions set on these files.
> For example, read-only libtoolize system package will copy those
> files without write permissions. This causes build to fail as next
> line copies ./include/install-sh over ./install-sh which will fail.
> 
> Fix this by setting permission explicitly on files copied by libtoolize.
> 
> See similar commit in xfsprogs:
> 6b32423addd2 ("xfsprogs: fix permissions on files installed by libtoolize")
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>

Looks ok,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  Makefile | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index a48d8d62f038..6c3de609bf38 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -76,6 +76,9 @@ endif
>  
>  configure: configure.ac
>  	libtoolize -cfi
> +	chmod 755 config.guess config.sub install-sh
> +	chmod 644 ltmain.sh m4/libtool.m4 m4/ltoptions.m4 m4/ltsugar.m4 \
> +		m4/ltversion.m4 m4/lt~obsolete.m4
>  	cp include/install-sh .
>  	aclocal -I m4
>  	autoheader
> -- 
> 2.54.0
> 
>