From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com
Cc: Frank.Li@kernel.org, imx@lists.linux.dev, linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/2] serial: amba-pl011: use dmaengine public API instead of raw ops
Date: Fri, 25 Sep 2026 20:16:27 +0000 [thread overview]
Message-ID: <20260925201628.80F441F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260925200850.1678179-2-Frank.Li@oss.nxp.com>
> From: Frank Li <Frank.Li@nxp.com>
>
> Replace direct calls to the internal DMA device ops
> (device->device_tx_status() and device->device_issue_pending())
> with the proper public DMA engine wrappers:
> - dmaengine_tx_status()
> - dma_async_issue_pending()
>
> Drivers must not call device ops directly; the wrappers provide
> locking, debug checks, and a stable interface that hides internal
> implementation details of the DMA controller driver.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260925200850.1678179-1-Frank.Li@oss.nxp.com?part=2
next prev parent reply other threads:[~2026-09-25 20:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 20:08 [PATCH 1/2] serial: use dmaengine_get_dma_device() instead of chan->device->dev Frank.Li
2026-09-25 20:08 ` [PATCH 2/2] serial: amba-pl011: use dmaengine public API instead of raw ops Frank.Li
2026-09-25 20:16 ` sashiko-bot [this message]
2026-09-25 20:19 ` [PATCH 1/2] serial: use dmaengine_get_dma_device() instead of chan->device->dev sashiko-bot
2026-09-28 8:51 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925201628.80F441F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.