All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Monette <pmonette@google.com>
To: git@vger.kernel.org
Cc: newren@gmail.com, ps@pks.im, toon@iotcl.com,
	 Patrick Monette <pmonette@google.com>
Subject: [PATCH 0/2] replay: add signing support
Date: Fri, 25 Sep 2026 16:53:46 -0400	[thread overview]
Message-ID: <20260925205348.1210154-1-pmonette@google.com> (raw)

This pair of commits fixes a FIXME in replay.c. With this, it's possible
to sign commits using `git replay`.

To follow the convention of git plumbing commands, where they must
behave the same regardless of user config, `commit.gpgSign` is
intentionally ignored.

The first patch fixes pick_regular_commit() to ensure failures to create
commits are correctly handled, which can now happen more easily because
of signing.

Patrick Monette (2):
  replay: handle failure to create commits
  replay: add the -S option

 Documentation/git-replay.adoc |  10 +++-
 builtin/replay.c              |  12 +++-
 replay.c                      |  17 ++++--
 replay.h                      |   6 ++
 t/meson.build                 |   1 +
 t/t3651-replay-gpg-sign.sh    | 107 ++++++++++++++++++++++++++++++++++
 6 files changed, 146 insertions(+), 7 deletions(-)
 create mode 100755 t/t3651-replay-gpg-sign.sh

-- 
2.56.0.rc1.315.gc6ed9934b7-goog


             reply	other threads:[~2026-09-25 20:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 20:53 Patrick Monette [this message]
2026-09-25 20:53 ` [PATCH 1/2] replay: handle failure to create commits Patrick Monette
2026-09-28  7:41   ` Patrick Steinhardt
2026-09-25 20:53 ` [PATCH 2/2] replay: add the -S option Patrick Monette
2026-09-28  7:41   ` Patrick Steinhardt
2026-10-02 21:23   ` Junio C Hamano
2026-09-28  7:41 ` [PATCH 0/2] replay: add signing support Patrick Steinhardt
2026-09-28 15:23   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260925205348.1210154-1-pmonette@google.com \
    --to=pmonette@google.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=ps@pks.im \
    --cc=toon@iotcl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.