Re: [PATCH bpf-next v1 08/12] bpf: Check subprog dynptr arguments in the common path

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] bpf: multi-line comment violates BPF subsystem formatting style
--

commit 45344ee9671457679fb9b5565dcee5c8036d67b0
Author: Amery Hung <ameryhung@gmail.com>

bpf: Check subprog dynptr arguments in the common path

This commit updates the verifier to check subprog and helper/kfunc
dynptr arguments through the common check_func_arg() path. It also modifies
a selftest to ensure both Clang and GCC exercise the intended register-type
mismatch correctly.

> diff --git a/tools/testing/selftests/bpf/progs/dynptr_fail.c b/tools/testing/selftests/bpf/progs/dynptr_fail.c
> index 9418dfe4d7b7f..148cf44173221 100644
> --- a/tools/testing/selftests/bpf/progs/dynptr_fail.c
> +++ b/tools/testing/selftests/bpf/progs/dynptr_fail.c

[ ... ]

>  SEC("?raw_tp")
> -__failure __msg("R1 expected pointer to stack or const struct bpf_dynptr")
> +__failure __msg("R1 type=trusted_ptr_ expected=fp, dynptr_ptr")
>  int test_dynptr_reg_type(void *ctx)
>  {
> -	struct task_struct *current = NULL;
> -	/* R1 should be holding a PTR_TO_BTF_ID, so this shouldn't be a
> -	 * reg->type that can be passed to a function accepting a
> -	 * ARG_PTR_TO_DYNPTR | MEM_RDONLY. process_dynptr_func() should catch
> -	 * this.
> +	struct task_struct *current = bpf_get_current_task_btf();
> +	/* R1 holds a PTR_TO_BTF_ID, which cannot be passed to a function
> +	 * accepting ARG_PTR_TO_DYNPTR | MEM_RDONLY.

[Severity: Low]
This isn't a bug, but the BPF subsystem follows the modern kernel
multi-line comment style where the opening /* must be on its own line.
Should this comment block be updated to match the required formatting?

>  	 */
>  	global_call_bpf_dynptr((const struct bpf_dynptr *)current);
>  	return 0;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925211256.1834061-1-ameryhung@gmail.com?part=8