Re: [PATCH 01/10] mount_service: move the command line check into arg_in_cmdline()

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Sep 25, 2026 at 12:23:29AM +0200, Bernd Schubert via B4 Relay wrote:
> From: Bernd Schubert <bernd@bsbernd.com>
> 
> mount_service_handle_mountpoint_cmd() compared the mount point with
> each argument of fuservicemount3 in its own loop. The next patch makes
> the same check for OPEN requests, so the loop moves into
> arg_in_cmdline(). There is no change in behaviour.
> 
> Assisted-by: LLM
> Signed-off-by: Bernd Schubert <bernd@bsbernd.com>

This is a reasonable hoist so
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  util/mount_service.c | 22 +++++++++++++---------
>  1 file changed, 13 insertions(+), 9 deletions(-)
> 
> diff --git a/util/mount_service.c b/util/mount_service.c
> index 0b3266309a8a..7549e0b5024f 100644
> --- a/util/mount_service.c
> +++ b/util/mount_service.c
> @@ -758,6 +758,18 @@ static int prepare_bdev(const struct mount_service *mo,
>  	return 0;
>  }
>  
> +static bool arg_in_cmdline(int argc, const char * const argv[],
> +			   const char *value)
> +{
> +	int i;
> +
> +	for (i = 0; i < argc; i++)
> +		if (!strcmp(argv[i], value))
> +			return true;
> +
> +	return false;
> +}
> +
>  static int mount_service_open_path(const struct mount_service *mo,
>  				   mode_t expected_fmt,
>  				   struct fuse_service_packet *p, size_t psz)
> @@ -1248,8 +1260,6 @@ static int mount_service_handle_mountpoint_cmd(struct mount_service *mo,
>  			container_of(p, struct fuse_service_mountpoint_command, p);
>  	char *mntpt;
>  	mode_t expected_fmt;
> -	bool foundit = false;
> -	int i;
>  
>  	if (psz < sizeof_fuse_service_mountpoint_command(1)) {
>  		fprintf(stderr, "%s: mount point command too small\n",
> @@ -1289,13 +1299,7 @@ static int mount_service_handle_mountpoint_cmd(struct mount_service *mo,
>  	}
>  
>  	/* Mountpoint must be mentioned in the caller's argument list */
> -	for (i = 0; i < argc; i++) {
> -		if (!strcmp(argv[i], oc->value)) {
> -			foundit = true;
> -			break;
> -		}
> -	}
> -	if (!foundit) {
> +	if (!arg_in_cmdline(argc, argv, oc->value)) {
>  		fprintf(stderr, "%s: mount point must be in command line arguments\n",
>  			mo->msgtag);
>  		return mount_service_send_reply(mo, EINVAL);
> 
> -- 
> 2.53.0
> 
> 
>