From: Hajime Tazaki <thehajime@gmail.com>
To: linux-mm@kvack.org, liam@infradead.org, rbm@suse.com,
akpm@linux-foundation.org, luto@amacapital.net,
brendan.jackman@linux.dev, david@kernel.org,
liuhangbin@gmail.com, corbet@lwn.net, kees@kernel.org,
ljs@kernel.org, broonie@kernel.org, mhocko@suse.com,
rppt@kernel.org, shuah@kernel.org, surenb@google.com,
vbabka@kernel.org, wad@chromium.org, linux-doc@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-um@lists.infradead.org
Cc: geert@linux-m68k.org, daniel@thingy.jp,
Hajime Tazaki <thehajime@gmail.com>
Subject: [PATCH v3 1/3] selftests: kselftest: avoid cd - in runner
Date: Sat, 26 Sep 2026 10:08:17 +0900 [thread overview]
Message-ID: <20260926010819.604346-2-thehajime@gmail.com> (raw)
In-Reply-To: <20260926010819.604346-1-thehajime@gmail.com>
The kselftest runner currently uses `cd -` to restore its working
directory after running a test.
This is not supported by the minimal BusyBox hush shell used by some
NOMMU targets. Store the original directory explicitly and restore it
with a quoted path instead.
This also avoids printing the directory change performed by `cd -` and
handles paths containing whitespace correctly.
Cc: Shuah Khan <shuah@kernel.org>
Cc: Kees Cook <kees@kernel.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Will Drewry <wad@chromium.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Brendan Jackman <brendan.jackman@linux.dev>
Cc: Hangbin Liu <liuhangbin@gmail.com>
Cc: "Ricardo B. Marliere" <rbm@suse.com>
Cc: linux-kselftest@vger.kernel.org
Cc: linux-um@lists.infradead.org
Cc: linux-mm@kvack.org
Signed-off-by: Hajime Tazaki <thehajime@gmail.com>
---
tools/testing/selftests/kselftest/runner.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh
index 311811dc55a0..8fc1018d6fec 100644
--- a/tools/testing/selftests/kselftest/runner.sh
+++ b/tools/testing/selftests/kselftest/runner.sh
@@ -130,6 +130,7 @@ run_one()
return $KSFT_FAIL
fi
fi
+ OLDDIR=$(pwd)
cd `dirname $TEST` > /dev/null
(((( tap_timeout "$cmd" 2>&1; echo $? >&3) |
tap_prefix >&4) 3>&1) |
@@ -147,7 +148,7 @@ run_one()
*)
ktap_test_fail "$TEST_HDR_MSG # exit=$rc";;
esac
- cd - >/dev/null
+ cd "$OLDDIR" >/dev/null
fi
return $rc
--
2.43.0
next prev parent reply other threads:[~2026-09-26 1:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 1:08 [PATCH v3 0/3] support kselftest on nommu platform Hajime Tazaki
2026-09-26 1:08 ` Hajime Tazaki [this message]
2026-09-28 9:25 ` [PATCH v3 1/3] selftests: kselftest: avoid cd - in runner David Hildenbrand (Arm)
2026-09-28 11:02 ` Lorenzo Stoakes (ARM)
2026-09-28 17:27 ` Pedro Falcato
2026-09-28 18:16 ` Pedro Falcato
2026-09-29 1:05 ` Hajime Tazaki
2026-09-26 1:08 ` [PATCH v3 2/3] selftests: run tests on nommu architecture Hajime Tazaki
2026-09-28 7:44 ` Johannes Berg
2026-09-28 11:00 ` Lorenzo Stoakes (ARM)
2026-09-28 12:32 ` Johannes Berg
2026-09-28 16:23 ` Lorenzo Stoakes (ARM)
2026-09-29 1:03 ` Hajime Tazaki
2026-09-28 11:03 ` Lorenzo Stoakes (ARM)
2026-09-26 1:08 ` [PATCH v3 3/3] selftests/nommu: add nommu mmap and mremap behavior tests Hajime Tazaki
2026-09-28 12:34 ` Mark Brown
2026-09-29 1:06 ` Hajime Tazaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926010819.604346-2-thehajime@gmail.com \
--to=thehajime@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=brendan.jackman@linux.dev \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@thingy.jp \
--cc=david@kernel.org \
--cc=geert@linux-m68k.org \
--cc=kees@kernel.org \
--cc=liam@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-um@lists.infradead.org \
--cc=liuhangbin@gmail.com \
--cc=ljs@kernel.org \
--cc=luto@amacapital.net \
--cc=mhocko@suse.com \
--cc=rbm@suse.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.