All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [frank-w-bpi-r2-4.14:7.2-main 214/214] drivers/net/ethernet/mediatek/mtk_eth_path.c:225:2-3: Unneeded semicolon
Date: Sat, 26 Sep 2026 02:58:51 +0200	[thread overview]
Message-ID: <202609260237.LuwsFS0v-lkp@intel.com> (raw)

tree:   https://github.com/frank-w/BPI-R2-4.14 7.2-main
head:   27e8d41a42f73cb2b271df0e897e25224889f6d0
commit: ac31c86a941e02ff8f91a2f7b5e171352ccf9b03 [214/214] net: ethernet: mtk_eth_soc: add paths and SerDes modes for MT7988
config: sparc64-randconfig-r2104-20260925 (https://download.01.org/0day-ci/archive/20260926/202609260237.LuwsFS0v-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 15.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609260237.LuwsFS0v-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/mediatek/mtk_eth_path.c:225:2-3: Unneeded semicolon
--
>> drivers/net/ethernet/mediatek/mtk_eth_soc.c:557:2-3: Unneeded semicolon

vim +225 drivers/net/ethernet/mediatek/mtk_eth_path.c

   200	
   201	static int set_mux_gmac123_to_usxgmii(struct mtk_eth *eth, u64 path)
   202	{
   203		unsigned int val = 0;
   204		bool updated = true;
   205		int mac_id = 0;
   206	
   207		/* Disable SYSCFG1 SGMII */
   208		regmap_read(eth->ethsys, ETHSYS_SYSCFG0, &val);
   209	
   210		switch (path) {
   211		case MTK_ETH_PATH_GMAC1_USXGMII:
   212			val &= ~(u32)SYSCFG0_SGMII_GMAC1_V2;
   213			mac_id = MTK_GMAC1_ID;
   214			break;
   215		case MTK_ETH_PATH_GMAC2_USXGMII:
   216			val &= ~(u32)SYSCFG0_SGMII_GMAC2_V2;
   217			mac_id = MTK_GMAC2_ID;
   218			break;
   219		case MTK_ETH_PATH_GMAC3_USXGMII:
   220			val &= ~(u32)SYSCFG0_SGMII_GMAC3_V2;
   221			mac_id = MTK_GMAC3_ID;
   222			break;
   223		default:
   224			updated = false;
 > 225		};
   226	
   227		if (updated) {
   228			regmap_update_bits(eth->ethsys, ETHSYS_SYSCFG0,
   229					   SYSCFG0_SGMII_MASK, val);
   230	
   231			if (mac_id == MTK_GMAC2_ID)
   232				regmap_set_bits(eth->infra, TOP_MISC_NETSYS_PCS_MUX,
   233						MUX_G2_USXGMII_SEL);
   234		}
   235	
   236		dev_dbg(eth->dev, "path %s in %s updated = %d\n",
   237			mtk_eth_path_name(path), __func__, updated);
   238	
   239		return 0;
   240	}
   241	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-09-26  0:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202609260237.LuwsFS0v-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=frank-w@public-files.de \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.