Re: [PATCH 8/8] arm64: dts: qcom: sm6350-lena: Enable PMK8350

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: unit address vs reg mismatch in pmk8350_vadc channel
--

commit 5d60ecb2f51ba076b9f89e76eff7eec7d8346935
Author: erebion <erebion@erebion.eu>

arm64: dts: qcom: sm6350-lena: Enable PMK8350

Configure and enable nodes for PMK8350 on the Xperia 10 III.

> diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> index 265400aa945ba..ddca3caf4a4e5 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts

[ ... ]

> @@ -436,6 +441,31 @@ &pm7250b_vbus {

[ ... ]

> +&pmk8350_vadc {
> +	channel@3100 {
> +		reg = <PMK8350_ADC7_AMUX_THM1_100K_PU>;

[Severity: Low]
The node name uses the unit address 3100, but because PMK8350_SID is 6
and ADC7_AMUX_THM1_100K_PU is 0x44, the reg expression (6 << 8 | 0x44)
evaluates to 0x644.

This mismatch triggers a unit_address_vs_reg warning from the device tree
compiler during the build.

Could the unit address in the pmk8350_vadc node name be updated to 644 to
match the evaluated register address?

> +		qcom,ratiometric;
> +		qcom,hw-settle-time = <200>;
> +		qcom,pre-scaling = <1 1>;
> +		label = "xo_therm";
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260926-pdx213-upstream-3-v1-0-1609c18b5c1d@erebion.eu?part=8