Re: [PATCH 1/3] dt-bindings: reset: mediatek: add MT7629 TOPRGU reset indices

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: watchdog: mediatek: missing #reset-cells constraint
--

commit 8696685eaee46e4451438ad7ac853addff28818b
Author: Chuanhong Guo <gch981213@gmail.com>

dt-bindings: reset: mediatek: add MT7629 TOPRGU reset indices

This commit defines all seven reset IDs documented in the MT7629 TOPRGU
SWSYSRST register. It uses their register bit positions as the reset IDs.

> diff --git a/include/dt-bindings/reset/mt7629-resets.h b/include/dt-bindings/reset/mt7629-resets.h
> index 6bb85734f68d8..828919eee2982 100644
> --- a/include/dt-bindings/reset/mt7629-resets.h
> +++ b/include/dt-bindings/reset/mt7629-resets.h
> @@ -53,6 +53,15 @@
>  #define MT7629_PCIE0_USER_RST			30
>  #define MT7629_PCIE0_PIPE_RST			31
>  
> +/* TOPRGU resets */
> +#define MT7629_TOPRGU_INFRA_SW_RST		0
> +#define MT7629_TOPRGU_ETHDMA_SW_RST		1
> +#define MT7629_TOPRGU_DDRPHY_SW_RST		6
> +#define MT7629_TOPRGU_INFRA_AO_SW_RST		8
> +#define MT7629_TOPRGU_CONN_SW_RST		9
> +#define MT7629_TOPRGU_APMIXED_SW_RST		10
> +#define MT7629_TOPRGU_CONN_MCU_SW_RST		12

[Severity: Low]
Since this patch introduces reset provider capabilities for MT7629, does
Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml also need
to be updated in this commit to require #reset-cells for mediatek,mt7629-wdt?

Incomplete device tree nodes lacking the #reset-cells property for the MT7629
watchdog will silently pass schema validation, violating the subsystem rule
that providers must enforce their required properties.

I note this is corrected later in Patch 3 of the series so there is no
runtime impact, but static validation via dt_binding_check will be incomplete
at this specific commit.

> +
>  /* SSUSB Subsystem resets */
>  #define MT7629_SSUSB_PHY_PWR_RST		3
>  #define MT7629_SSUSB_MAC_PWR_RST		4

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260926-b4-mt7629-toprgu-v1-0-c124bf9ac273@gmail.com?part=1