Re: [PATCH v2 16/17] arm64: dts: apple: t6030: add avd nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: undocumented compatible string 'apple,t6030-dart'
--

commit a86b2ab51c200171749c5b4ddd9cf551f1bd6ec3
Author: Sofus Forstreuter <sofus.c@icloud.com>

arm64: dts: apple: t6030: add avd nodes

This commit adds the AVD DART and video codec nodes to the Apple T6030
devicetree.

> diff --git a/arch/arm64/boot/dts/apple/t6030.dtsi b/arch/arm64/boot/dts/apple/t6030.dtsi
> index dda9568af11f9..805042bd9270d 100644
> --- a/arch/arm64/boot/dts/apple/t6030.dtsi
> +++ b/arch/arm64/boot/dts/apple/t6030.dtsi
> @@ -361,6 +361,38 @@ pmgr_gfx: power-management@290e80000 {
>  			/* child nodes are added in t6030-pmgr.dtsi */
>  		};
>  
> +		avd_dart: iommu@30b010000 {
> +			compatible = "apple,t6030-dart", "apple,t8110-dart";

[Severity: Low]
Is this compatible string defined in the devicetree bindings?

The patch adds an IOMMU node with the compatible string 'apple,t6030-dart',
but this string does not appear to be defined in
Documentation/devicetree/bindings/iommu/apple,dart.yaml.

Will this omission leave the hardware interface undocumented and cause
make dtbs_check validation to fail for the new devicetree?

> +			reg = <0x3 0x0b010000 0x0 0x4000>;
> +			interrupt-parent = <&aic>;
> +			interrupts = <AIC_IRQ 795 IRQ_TYPE_LEVEL_HIGH>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260926-avd-v2-0-ecebe6a3648e@icloud.com?part=16