Re: [PATCH v1 09/11] ARM: dts: imx6ull: Add Variscite i.MX6ULL board variants

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: unreferenced reg_sd1_vmmc regulator in SD card overlays
--

commit 84f1f5ed8d2b37074235e31176f412cbd893a3be
Author: Stefano Radaelli <stefano.r@variscite.com>
Subject: ARM: dts: imx6ull: Add Variscite i.MX6ULL board variants

This patch adds i.MX6ULL board Device Tree Source files for the VAR-SOM-6UL
and DART-6UL platforms. It enables their respective carrier, storage, wireless,
and audio options. Shared option and carrier descriptions are reused with the
i.MX6ULL SoC and module wrappers.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-var-dart-emmc-sd-card-6ulcustomboard.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-var-dart-emmc-sd-card-6ulcustomboard.dts
> new file mode 100644
> index 0000000000000..ef75c773a5eed
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-var-dart-emmc-sd-card-6ulcustomboard.dts
> @@ -0,0 +1,20 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com
> + */
> +
> +/dts-v1/;
> +
> +#include "imx6ull.dtsi"
> +#include "imx6ull-var-dart.dtsi"
> +#include "imx6ul-imx6ull-var-dart-emmc.dtsi"
> +#include "imx6ul-imx6ull-var-dart-wm8904.dtsi"
> +#include "imx6ull-var-dart-6ulcustomboard.dtsi"
> +#include "imx6ul-imx6ull-var-dart-6ulcustomboard-sd-card.dtsi"

[Severity: Low]
Is the reg_sd1_vmmc regulator meant to be assigned to the SD card controller
in this overlay?

Looking at the included imx6ul-imx6ull-var-dart-6ulcustomboard-sd-card.dtsi
file:

&usdhc1 {
	pinctrl-names = "default";
	pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_usdhc1_gpio>;
	cd-gpios = <&gpio4 19 GPIO_ACTIVE_LOW>;
	no-1-8-v;
	keep-power-in-suspend;
	wakeup-source;
	status = "okay";
};

The reg_sd1_vmmc fixed regulator is defined in that file but never assigned
to usdhc1 via the vmmc-supply property. This leaves the regulator
unreferenced and the hardware description incomplete.

[ ... ]

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-var-som-emmc-sd-card-concerto-board.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-var-som-emmc-sd-card-concerto-board.dts
> new file mode 100644
> index 0000000000000..8b43ab375592a
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-var-som-emmc-sd-card-concerto-board.dts
> @@ -0,0 +1,20 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com
> + */
> +
> +/dts-v1/;
> +
> +#include "imx6ull.dtsi"
> +#include "imx6ull-var-som.dtsi"
> +#include "imx6ul-imx6ull-var-som-emmc.dtsi"
> +#include "imx6ul-imx6ull-var-som-wm8904.dtsi"
> +#include "imx6ull-var-som-concerto-board.dtsi"
> +#include "imx6ul-imx6ull-var-som-concerto-board-sd-card.dtsi"

[Severity: Low]
Could vmmc-supply also be missing for the concerto board SD card overlay?

In the included imx6ul-imx6ull-var-som-concerto-board-sd-card.dtsi:

&usdhc1 {
	pinctrl-names = "default";
	pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_usdhc1_gpio>;
	cd-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
	no-1-8-v;
	keep-power-in-suspend;
	wakeup-source;
	status = "okay";
};

Similar to the dart board variant, reg_sd1_vmmc is explicitly defined but
is never assigned to usdhc1 here either.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790344389.git.stefano.r@variscite.com?part=9