From: Jon Simons <jon@jonsimons.org>
To: git@vger.kernel.org
Cc: Jon Simons <jon@jonsimons.org>
Subject: [PATCH] p5551: fix repeated runs with update-ref --no-deref
Date: Sat, 26 Sep 2026 14:06:48 -0400 [thread overview]
Message-ID: <20260926180648.60770-1-jon@jonsimons.org> (raw)
Update p5551-fetch-rescan.sh to pass `--no-deref` when deleting child
test refs before each measured `git fetch`. Otherwise, for repeated
runs, the second iteration will fail with:
fatal: multiple updates for 'refs/remotes/origin/master' (including
one via symref 'refs/remotes/origin/HEAD') are not allowed
Starting with 3f763ddf28 (fetch: set remote/HEAD if it does not exist,
2024-11-22), `git fetch` instantiates the HEAD symref.
The test, introduced in 7893bf1720 (p5551: add a script to test fetch
pack-dir rescans, 2017-11-20), predates that.
Signed-off-by: Jon Simons <jon@jonsimons.org>
---
t/perf/p5551-fetch-rescan.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/perf/p5551-fetch-rescan.sh b/t/perf/p5551-fetch-rescan.sh
index b99dc23e32..0b3ff632fc 100755
--- a/t/perf/p5551-fetch-rescan.sh
+++ b/t/perf/p5551-fetch-rescan.sh
@@ -45,7 +45,7 @@ test_perf 'fetch' '
(
cd child &&
$MODERN_GIT for-each-ref --format="delete %(refname)" refs/remotes |
- $MODERN_GIT update-ref --stdin &&
+ $MODERN_GIT update-ref --stdin --no-deref &&
rm -vf .git/objects/$(echo $obj | sed "s|^..|&/|") &&
git fetch
base-commit: 0f8e75abebff0877cae681a3d5ff31ac47f54220
--
2.55.0
next reply other threads:[~2026-09-26 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 18:06 Jon Simons [this message]
2026-09-28 4:05 ` [PATCH] p5551: fix repeated runs with update-ref --no-deref Jeff King
2026-09-28 18:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926180648.60770-1-jon@jonsimons.org \
--to=jon@jonsimons.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.