Re: [PATCH net-next v23 1/9] dt-bindings: net: dsa: Document support for Airoha AN8855 DSA Switch

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: unresolved phandles in example will cause dt_binding_check to fail
--

commit 149759f83399f8efe1a862e7d0f5637ed4300bbc
Author: Christian Marangi <ansuelsmth@gmail.com>

dt-bindings: net: dsa: Document support for Airoha AN8855 DSA Switch

This commit introduces a new YAML device tree binding to document support for 
the Airoha AN8855 5-port Gigabit Switch. It describes the exposed internal 
PHYs on the MDIO bus.

> diff --git a/Documentation/devicetree/bindings/net/dsa/airoha,an8855-switch.yaml b/Documentation/devicetree/bindings/net/dsa/airoha,an8855-switch.yaml
> new file mode 100644
> index 0000000000000..5ad9b9e139831
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dsa/airoha,an8855-switch.yaml
[ ... ]
> +examples:
> +  - |
> +    ethernet-switch {
> +        compatible = "airoha,an8855-switch";
> +
> +        ports {
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            port@0 {
> +                reg = <0>;
> +                label = "lan1";
> +                phy-mode = "internal";
> +                phy-handle = <&internal_phy1>;

[Severity: Low]
Will this example pass make dt_binding_check? The device tree compiler strictly
checks for label existence, and it looks like the internal_phy1 label (along
with the other phy labels) is not defined within this example block. This
might cause dtc to report a fatal "Reference to non-existent node or label"
error during the validation build.

> +            };
[ ... ]
> +            port@4 {
> +                reg = <4>;
> +                label = "wan";
> +                phy-mode = "internal";
> +                phy-handle = <&internal_phy5>;
> +            };
> +
> +            port@5 {
> +                reg = <5>;
> +                label = "cpu";
> +                ethernet = <&gmac0>;

[Severity: Low]
Similar to the phy-handle references, is the gmac0 label defined in this
example? Leaving this undefined could also trigger a reference compilation
error when the example is extracted and built.

> +                phy-mode = "2500base-x";
> +
> +                fixed-link {
> +                    speed = <2500>;
> +                    full-duplex;
> +                    pause;
> +                };
> +            };
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925182435.21207-1-ansuelsmth@gmail.com?part=1