From: sashiko-bot@kernel.org
To: "Michal Pluta" <michalpl2003@gmail.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 8/8] perf bench futex: Fix wording in futex bench messages
Date: Sat, 26 Sep 2026 19:13:36 +0000 [thread overview]
Message-ID: <20260926191337.3E6781F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260926190407.1106421-9-michalpl2003@gmail.com>
> When the kernel is using a different number of hash buckets than
> requested with -b, the message printed is ungrammatical, and it ends
> with a stale errno even though nothing failed:
>
> Requested number of hash buckets does not currently used.
> Requested: 3 in usage: 64
> perf: prctl(PR_FUTEX_HASH): No such file or directory
>
> Fix the wording and use errx(), so that no errno text is printed:
>
> Requested number of buckets differs from the number in use.
> Requested: 3, in use: 64
> perf: prctl(PR_FUTEX_HASH)
>
> Also fix "Wokeup" in the 'futex wake' output, which should be "Woke up".
>
> Fixes: 60035a3981a7 ("tools/perf: Allow to select the number of hash buckets")
> Assisted-by: LLM
> Signed-off-by: Michal Pluta <michalpl2003@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260926190407.1106421-1-michalpl2003@gmail.com?part=8
next prev parent reply other threads:[~2026-09-26 19:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 19:03 [PATCH 0/8] perf bench futex: Fix several bugs and bad inputs Michal Pluta
2026-09-26 19:04 ` [PATCH 1/8] perf bench futex: Retry futex_wait() when interrupted by a signal Michal Pluta
2026-09-26 19:13 ` sashiko-bot
2026-10-05 23:49 ` Namhyung Kim
2026-09-26 19:04 ` [PATCH 2/8] perf bench futex: Set the number of hash buckets in futex wake Michal Pluta
2026-09-26 19:09 ` sashiko-bot
2026-09-26 19:04 ` [PATCH 3/8] perf bench futex: Use the whole timeval for elapsed times Michal Pluta
2026-09-26 19:11 ` sashiko-bot
2026-10-05 23:54 ` Namhyung Kim
2026-09-26 19:04 ` [PATCH 4/8] perf bench futex: Reject invalid -q, -f and -b values Michal Pluta
2026-09-26 19:10 ` sashiko-bot
2026-09-26 19:04 ` [PATCH 5/8] perf bench futex: Stop when futex_wake() fails in futex wake Michal Pluta
2026-09-26 19:10 ` sashiko-bot
2026-09-26 19:04 ` [PATCH 6/8] perf bench futex: Use a 64-bit operation counter in hash and lock-pi Michal Pluta
2026-09-26 19:10 ` sashiko-bot
2026-09-26 19:04 ` [PATCH 7/8] perf bench futex: Clean up two nits in futex hash Michal Pluta
2026-09-26 19:10 ` sashiko-bot
2026-09-26 19:04 ` [PATCH 8/8] perf bench futex: Fix wording in futex bench messages Michal Pluta
2026-09-26 19:13 ` sashiko-bot [this message]
2026-10-05 23:57 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926191337.3E6781F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=michalpl2003@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.