From: sashiko-bot@kernel.org
To: "Arnaldo Carvalho de Melo" <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/1] perf timechart: Remove the unused use_old_power_events variable
Date: Sat, 26 Sep 2026 20:35:37 +0000 [thread overview]
Message-ID: <20260926203538.41BB91F000FF@smtp.kernel.org> (raw)
In-Reply-To: <argr21X4JoSl1O2W@x2>
> It is set once and never read: its only reader went away in
> 20c457b8587bee46 ("perf timechart: Adjust perf timechart to the new power
> events") and nothing used it since, so the assignment was dead code for
> 13 years.
>
> clang 23 extends -Wunused-but-set-variable to file-scope variables with
> internal linkage, under the new -Wunused-but-set-global subgroup, and
> with the -Werror that perf uses by default that turns the dead
> assignment into a build error:
>
> builtin-timechart.c:355:12: error: variable 'use_old_power_events' set but not used
> [-Werror,-Wunused-but-set-global]
>
> as seen building with clang 23.1.1 on Fedora 45 and rawhide, where gcc,
> older clang and clang without -Werror all keep building it.
>
> Assisted-by: LLM
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/argr21X4JoSl1O2W@x2?part=1
next prev parent reply other threads:[~2026-09-26 20:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 20:32 [PATCH 1/1] perf timechart: Remove the unused use_old_power_events variable Arnaldo Carvalho de Melo
2026-09-26 20:35 ` sashiko-bot [this message]
2026-09-26 22:47 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926203538.41BB91F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=acme@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.