Re: [PATCH net-next] dt-bindings: net: Convert hisilicon,hns-nic to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: incomplete port-id deprecation and validation constraint
--

commit fa2141e31377c486f984e5588eb02ffe70ed8443
Author: Rob Herring (Arm) <robh@kernel.org>

dt-bindings: net: Convert hisilicon,hns-nic to DT schema

Convert the hisilicon,hns-nic binding to DT schema format. It's a
straight forward conversion.

> diff --git a/Documentation/devicetree/bindings/net/hisilicon,hns-nic.yaml b/Documentation/devicetree/bindings/net/hisilicon,hns-nic.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/hisilicon,hns-nic.yaml
[ ... ]
> +properties:
> +  compatible:
> +    enum:
> +      - hisilicon,hns-nic-v1
> +      - hisilicon,hns-nic-v2
> +
> +  ae-handle:
> +    description:
> +      accelerator engine handle for hns, specifies a reference to the
> +      associating hardware driver node.
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +
> +  port-id:
> +    description: |
> +      is the index of port provided by DSAF (the accelerator). DSAF can connect to 8 PHYs.
> +      Port 0 to 1 are both used for administration purpose.

[Severity: Low]
The original text file mentioned the port-id attribute remains for 
compatibility purposes and is not recommended for new code. Should 
properties.port-id in Documentation/devicetree/bindings/net/hisilicon,hns-nic.yaml 
include a deprecated: true annotation here to preserve that constraint?

[ ... ]
> +  dma-coherent: true
> +
> +required:
> +  - compatible
> +  - ae-handle
> +  - port-idx-in-ae
> +  - local-mac-address

[Severity: Low]
Does unconditionally requiring port-idx-in-ae in the required list break 
dtbs_check schema validation for older device trees in 
Documentation/devicetree/bindings/net/hisilicon,hns-nic.yaml?

If legacy device trees rely on the port-id fallback without providing 
port-idx-in-ae, this strict requirement might cause validation errors 
when running schema checks on older configurations. Should this be 
conditionally required instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925215923.2950950-1-robh@kernel.org?part=1