From: sashiko-bot@kernel.org
To: "Nathan Chancellor" <nathan@kernel.org>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_mid: Add missing module namespace import for SERIAL_8250
Date: Sat, 26 Sep 2026 23:06:35 +0000 [thread overview]
Message-ID: <20260926230636.3D92B1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260927-tty-8250_mid-ns-import-v1-1-84d0482e1c5d@kernel.org>
> After commit 1c305d5f1daa ("serial: 8250_mid: wait for LSR tx empty
> before setting termios"), modpost errors (or warning with
> CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS=y):
>
> ERROR: modpost: drivers/tty/serial/8250/8250_mid.ko: module uses symbol 'serial8250_wait_for_xmitr' from namespace 'SERIAL_8250', but does not import it.
>
> Add the missing module namespace import to clear up the error/warning.
>
> Fixes: 1c305d5f1daa ("serial: 8250_mid: wait for LSR tx empty before setting termios")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260927-tty-8250_mid-ns-import-v1-1-84d0482e1c5d@kernel.org?part=1
next prev parent reply other threads:[~2026-09-26 23:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 23:01 [PATCH] serial: 8250_mid: Add missing module namespace import for SERIAL_8250 Nathan Chancellor
2026-09-26 23:06 ` sashiko-bot [this message]
2026-09-28 8:17 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926230636.3D92B1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.