All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Per Larsson <per@palvencia.se>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Chen-Yu Tsai <wens@kernel.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Liu Changjie <liucj1228@outlook.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-sunxi@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/6] arm64: dts: allwinner: a523: x96qpro+: enable Ethernet support
Date: Sun, 27 Sep 2026 01:18:15 +0200	[thread overview]
Message-ID: <20260927011815.66cc1769@ryzen.lan> (raw)
In-Reply-To: <20260901074827.39a649bc@rpi>

On Tue, 1 Sep 2026 07:48:27 +0200
Per Larsson <per@palvencia.se> wrote:

Hi Per,

thanks for having a good look at this!

> On Sun, 9 Aug 2026 13:46:07 +0200
> Per Larsson <per@palvencia.se> wrote:
> 
> > On Mon,  3 Aug 2026 12:14:52 +0200
> > Andre Przywara <andre.przywara@arm.com> wrote:
> > 
> > > +		pinctrl-0 = <&ephy_25m_pin>;  
> > 
> > This should be &ephy1_25m_pin, right?

Argh, of course. This was from an earlier version, with just one pin,
and I used that DT version in U-Boot for testing, so didn't notice.
Fixed now, of course, thanks for spotting!
 
> With this typo (and the one in patch 4/6) fixed, this series gets a
> Tested-by: Per Larsson <per@palvencia.se>

Thanks, added that, v2 is on its way.

Cheers,
Andre.

> since it eliminates the need to use hackier methods to get the ethernet
> port to work on this box.
> 



      reply	other threads:[~2026-09-26 23:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 10:14 [PATCH 0/6] sunxi: net: add Ethernet support for X96QPro+ Andre Przywara
2026-08-03 10:14 ` [PATCH 1/6] net: phy: maxio: prepare for more DT properties Andre Przywara
2026-08-04  2:42   ` Andrew Lunn
2026-08-03 10:14 ` [PATCH 2/6] net: phy: maxio: parse and enable PHY clock from generic DT binding Andre Przywara
2026-08-04  2:43   ` Andrew Lunn
2026-08-03 10:14 ` [PATCH 3/6] dt-bindings: net: Maxio PHY: add PHY-ID for -Q2C variant Andre Przywara
2026-08-12  1:34   ` Rob Herring (Arm)
2026-08-03 10:14 ` [PATCH 4/6] net: phy: maxio: extend PHY ID matching Andre Przywara
2026-08-03 14:59   ` Per Larsson
2026-08-04  2:49   ` Andrew Lunn
2026-08-03 10:14 ` [PATCH 5/6] arm64: dts: allwinner: a523: add EPHY 25MHz clock fanout pins Andre Przywara
2026-08-03 10:14 ` [PATCH 6/6] arm64: dts: allwinner: a523: x96qpro+: enable Ethernet support Andre Przywara
2026-08-04  2:53   ` Andrew Lunn
2026-08-04  3:11     ` Chen-Yu Tsai
2026-08-04 14:44       ` Andrew Lunn
2026-08-09 11:46   ` Per Larsson
2026-09-01  5:48     ` Per Larsson
2026-09-26 23:18       ` Andre Przywara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260927011815.66cc1769@ryzen.lan \
    --to=andre.przywara@arm.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=linux@armlinux.org.uk \
    --cc=liucj1228@outlook.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=per@palvencia.se \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.