Re: [PATCH v2 10/11] ARM: dts: imx6ulz: Add Variscite i.MX6ULZ board variants

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: combinatorial explosion of board permutations instead of using dt-overlays
--

commit 1ebac7e17fdd3ec057081a7015ef2c70ed9601c6
Author: Stefano Radaelli <stefano.r@variscite.com>

ARM: dts: imx6ulz: Add Variscite i.MX6ULZ board variants

Add i.MX6ULZ board DTS files for VAR-SOM-6UL and DART-6UL with their
carrier, storage, wireless and audio options.

Reuse the shared option and carrier descriptions with the i.MX6ULZ
SoC and module wrappers.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-var-dart-emmc-sd-card-wm8731-6ulcustomboard.dts b/arch/arm/boot/dts/nxp/imx/imx6ulz-var-dart-emmc-sd-card-wm8731-6ulcustomboard.dts
> new file mode 100644
> index 0000000000000..f102909e10850
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-var-dart-emmc-sd-card-wm8731-6ulcustomboard.dts
> @@ -0,0 +1,21 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com
> + */
> +
> +/dts-v1/;
> +
> +#include "imx6ulz.dtsi"
> +#include "imx6ulz-var-dart.dtsi"
> +#include "imx6ul-imx6ull-var-dart-emmc.dtsi"
> +#include "imx6ul-imx6ull-var-wm8731.dtsi"
> +#include "imx6ulz-var-dart-6ulcustomboard.dtsi"
> +#include "imx6ul-imx6ull-var-dart-6ulcustomboard-sd-card.dtsi"
> +
> +/ {
> +	model = "Variscite DART-6UL with i.MX6ULZ, eMMC, SD card & WM8731 support on VAR-6ULCustomBoard";

[Severity: Low]
Does this combinatorial explosion of board permutations create unnecessary code
complexity?

This file is one example of the 30 standalone .dts files added in this patch
that merely include a few common .dtsi files to represent every permutation of
storage, Wi-Fi, and audio options. This leads to build-time bloat and an
unmaintainable number of permutations for a single SoC.

Could this be handled instead by providing a base board .dts combined with
Device Tree Overlays (.dtso) for the optional modules, a pattern already
supported and actively used in arch/arm/boot/dts/nxp/imx/ (e.g., for dhcom and
colibri boards)?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790413032.git.stefano.r@variscite.com?part=10