Re: [RFC PATCH v4 6/7] Docs/admin-guide/mm/damon/usage: update for quota goal complement file

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] damon: build error in core-kunit.h due to typo complementfalse
--

commit eec8b1a2e73ee2822f8574a7a1b78a43cc0fed67
Author: SJ Park <sj@kernel.org>

Docs/admin-guide/mm/damon/usage: update for quota goal complement file

Update DAMON usage document for the newly added quota goal metric
complement sysfs file.

> diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
> index df84d9cc7d204..6a13d9bd377cb 100644
> --- a/mm/damon/tests/core-kunit.h
> +++ b/mm/damon/tests/core-kunit.h

[ ... ]

> @@ -930,6 +932,7 @@ static void damos_test_commit_quota_goals_for(struct kunit *test,
>  		 * Make it kfree()-able.
>  		 */
>  		goal = damos_new_quota_goal(dst_goals[i].metric,
> +				dst_goals[i].complementfalse,

[Severity: Low]
Does this regression cause a compilation failure when building with damon
kunit tests enabled? It looks like struct damos_quota_goal has a member
named complement, but not complementfalse in
damos_test_commit_quota_goals_for().

>  				dst_goals[i].target_value);
>  		if (!goal)
>  			goto out;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260927120533.50484-1-sj@kernel.org?part=6