From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Ravi Kerur <rkerur@brocade.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: fail initialization if TSC frequency is zero
Date: Sun, 27 Sep 2026 13:09:44 -0700 [thread overview]
Message-ID: <20260927130944.6e3d8f4b@phoenix.local> (raw)
In-Reply-To: <20260927195440.89193-1-stephen@networkplumber.org>
On Sun, 27 Sep 2026 12:54:40 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> + /*
> + * Several get_tsc_freq_arch() implementations return zero when the
> + * frequency cannot be read, and a TSC that does not advance at least
> + * once per second measures as zero. Such a counter cannot be scaled
> + * to a time at all, so fail rather than let callers of
> + * rte_get_tsc_hz() divide by zero.
> + */
> + if (freq == 0) {
> + EAL_LOG(ERR, "TSC frequency could not be determined");
> + return -1;
> + }
> +
Sorry for the AI generated comment here. Will fix in next version.
next prev parent reply other threads:[~2026-09-27 20:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 19:54 [PATCH] eal: fail initialization if TSC frequency is zero Stephen Hemminger
2026-09-27 20:09 ` Stephen Hemminger [this message]
2026-09-28 23:15 ` [PATCH v2] " Stephen Hemminger
2026-09-29 8:39 ` Bruce Richardson
2026-09-29 13:42 ` Stephen Hemminger
2026-09-29 13:57 ` Bruce Richardson
2026-09-29 14:10 ` Stephen Hemminger
2026-09-29 14:13 ` [PATCH v3] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927130944.6e3d8f4b@phoenix.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=rkerur@brocade.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.