Re: [PATCH v6 1/2] dt-bindings: clock: gpio-gate-clock: Add a new compatible string

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: clock: gpio-gate-clock: compatible string mismatch breaks validation
--

commit 2b809675a6d656fd8b8fcf12572b9880f2905a0c
Author: Vyacheslav Yurkov <V.Yurkov.EXT@bruker.com>

dt-bindings: clock: gpio-gate-clock: Add a new compatible string

Extend the binding to be used also for gpio-locked-fixed-clock.
A GPIO-locked fixed clock provider exposes a fixed-rate clock whose
availability depends on one or more GPIO lock-status signals.

> diff --git a/Documentation/devicetree/bindings/clock/gpio-gate-clock.yaml b/Documentation/devicetree/bindings/clock/gpio-gate-clock.yaml
> index d09d0e3f0c6ec..f44fdb17b627b 100644
> --- a/Documentation/devicetree/bindings/clock/gpio-gate-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/gpio-gate-clock.yaml
> @@ -11,7 +11,9 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: gpio-gate-clock
> +    enum:
> +      - gpio-gate-clock
> +      - gpio-locked-clock

[Severity: Low]
Does this missing "-fixed" suffix introduce a regression in validation? The
commit message, conditional block, and example below all use
"gpio-locked-fixed-clock", which will fail schema validation against this
enum.

[ ... ]

> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          const: gpio-gate-clock
> +    then:
> +      required:
> +        - enable-gpios
> +  - if:
> +      properties:
> +        compatible:
> +          const: gpio-locked-fixed-clock

[Severity: Low]
Does this compatible string mismatch introduce a regression in schema checks?
If the hardware uses "gpio-locked-clock" from the enum above, this
conditional won't match and will allow invalid nodes to pass validation
silently by bypassing the required "enabled-gpios" check.

> +    then:
> +      required:
> +        - enabled-gpios
>  
>  additionalProperties: false

[ ... ]

> @@ -40,3 +61,10 @@ examples:
>          #clock-cells = <0>;
>          enable-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;
>      };
> +
> +    clk_gpio_locked {
> +        compatible = "gpio-locked-fixed-clock";

[Severity: Low]
Will this compatible string cause a regression during dt_binding_check? The
example uses a string that does not match the allowed enum values defined
above.

> +        #clock-cells = <0>;
> +        clocks = <&pll>;
> +        enabled-gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>;
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260927-feature-clock-guard-v6-0-007983b13ec2@bruker.com?part=1