Re: [PATCH v8 1/2] dt-bindings: clock: gpio-gate-clock: Add a new compatible string

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] dt-bindings: clock: mismatch between commit message and compatible string
- [Medium] dt-bindings: clock: enabled-gpios maxItems restricted to 1 contradicting commit
- [Low] dt-bindings: clock: example node name uses invalid underscore characters
--

commit 27371721055a09fb1d350d670a8c103b2d13f3cd
Author: Vyacheslav Yurkov <V.Yurkov.EXT@bruker.com>

dt-bindings: clock: gpio-gate-clock: Add a new compatible string

This commit extends the gpio-gate-clock binding to support a GPIO-locked
fixed clock provider. The provider exposes a fixed-rate clock whose
availability depends on GPIO lock-status signals.

> diff --git a/Documentation/devicetree/bindings/clock/gpio-gate-clock.yaml b/Documentation/devicetree/bindings/clock/gpio-gate-clock.yaml
> index d09d0e3f0c6ec..1ad87c8b36b9f 100644
> --- a/Documentation/devicetree/bindings/clock/gpio-gate-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/gpio-gate-clock.yaml
> @@ -11,7 +11,9 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: gpio-gate-clock
> +    enum:
> +      - gpio-gate-clock
> +      - gpio-locked-clock

[Severity: Medium]
In the properties:compatible definition, the enum defines the string as
"gpio-locked-clock". The commit message states the binding is being extended
for "gpio-locked-fixed-clock". Could this mismatch cause confusion for users
and developers reading the commit log who might assume the compatible string
is "gpio-locked-fixed-clock" and attempt to use it?

[ ... ]

> @@ -23,10 +25,29 @@ properties:
>      description: GPIO reference for enabling and disabling the clock.
>      maxItems: 1
>  
> +  enabled-gpios:
> +    description: GPIO that indicates whether the clock is enabled or disabled.
> +    maxItems: 1

[Severity: Medium]
Does this maxItems constraint in properties:enabled-gpios match the intended
design? The commit message indicates the clock availability depends on "one
or more GPIO lock-status signals", but this property restricts the
configuration to a maximum of 1 item. Users attempting to provide more than
one GPIO based on the commit message will encounter schema validation
failures.

[ ... ]

> @@ -40,3 +61,10 @@ examples:
>          #clock-cells = <0>;
>          enable-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;
>      };
> +
> +    clk_gpio_locked {
> +        compatible = "gpio-locked-clock";

[Severity: Low]
In the examples section, is this node name compliant with device tree
conventions? Node names containing underscores generally trigger warnings
during device tree compilation (such as from dtc -W node_name_chars_strict).

> +        #clock-cells = <0>;
> +        clocks = <&pll>;
> +        enabled-gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>;
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260927-feature-clock-guard-v8-0-630938e302a1@bruker.com?part=1