Re: [PATCH] arm64: dts: renesas: r8a78000: Add I2C nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: missing prerequisite includes and nodes for i2c controllers
--

commit 3f7801bb0ea0ac6eb4aa58321a3d66e8c5413897
Author: Wolfram Sang <wsa+renesas@sang-engineering.com>

arm64: dts: renesas: r8a78000: Add I2C nodes

Add device nodes for the I2C controllers of the Renesas R-Car X5H (R8A78000)
SoC.

> diff --git a/arch/arm64/boot/dts/renesas/r8a78000.dtsi b/arch/arm64/boot/dts/renesas/r8a78000.dtsi
> index fb71974ef3905..a6a60d8930dec 100644
> --- a/arch/arm64/boot/dts/renesas/r8a78000.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a78000.dtsi
> @@ -877,6 +877,118 @@ gic: interrupt-controller@39000000 {
>  			interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
>  		};
>  
> +		i2c1: i2c@c06c0000 {
> +			compatible = "renesas,i2c-r8a78000",
> +				     "renesas,rcar-gen5-i2c";
> +			reg = <0 0xc06c0000 0 0x40>;
> +			interrupts = <GIC_SPI 956 IRQ_TYPE_LEVEL_HIGH>;
> +			i2c-scl-internal-delay-ns = <110>;
> +			clocks = <&cpg R8A78000_CPG_SGASYNCD8_PERW_BUS>;
> +			power-domains = <&mdlc_perw R8A78000_MDLC_PD_APL 0x44>;
> +			resets = <&mdlc_perw 0x44>;

[Severity: Low]
Will this device tree compile cleanly on the current baseline?

It looks like the R8A78000_CPG_SGASYNCD8_PERW_BUS and R8A78000_MDLC_PD_APL
macros, as well as the &cpg and &mdlc_perw phandles, are not yet defined in
the current tree.

Could this cause syntax errors and unresolved phandle references during the
build?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260927151133.45845-3-wsa+renesas@sang-engineering.com?part=1